Re: [PATCH v2] scsi: libsas: defer ata device eh commands to libata

2018-03-07 Thread John Garry
On 07/03/2018 09:18, Jack Wang wrote: 2018-03-07 8:47 GMT+01:00 Jason Yan : When ata device doing EH, some commands still attached with tasks are not passed to libata when abort failed or recover failed, so libata did not handle these commands. After these commands done, sas task is freed, but a

Re: [PATCH v2] scsi: libsas: defer ata device eh commands to libata

2018-03-07 Thread Dan Williams
On Tue, Mar 6, 2018 at 11:47 PM, Jason Yan wrote: > When ata device doing EH, some commands still attached with tasks are not > passed to libata when abort failed or recover failed, so libata did not > handle these commands. After these commands done, sas task is freed, but > ata qc is not freed.

Re: [PATCH v2] scsi: libsas: defer ata device eh commands to libata

2018-03-07 Thread Jack Wang
2018-03-07 8:47 GMT+01:00 Jason Yan : > When ata device doing EH, some commands still attached with tasks are not > passed to libata when abort failed or recover failed, so libata did not > handle these commands. After these commands done, sas task is freed, but > ata qc is not freed. This will cau

[PATCH v2] scsi: libsas: defer ata device eh commands to libata

2018-03-06 Thread Jason Yan
When ata device doing EH, some commands still attached with tasks are not passed to libata when abort failed or recover failed, so libata did not handle these commands. After these commands done, sas task is freed, but ata qc is not freed. This will cause ata qc leak and trigger a warning like belo