Re: [PATCH v2] scsi: handle special return codes for ABORTED COMMAND

2018-02-26 Thread Martin K. Petersen
Doug, > I checked the code for the ABORTED COMMAND asc=0x10 case. That is a > bunch of Protection Information errors which retrying would be > pointless. And the existing code does check for that just before the > new check for BLIST_ABORTED_CMD_QUIRK. The PI check has the cryptic > comment /* DI

Re: [PATCH v2] scsi: handle special return codes for ABORTED COMMAND

2018-02-26 Thread Martin K. Petersen
Martin, > Introduce a new blist flag that indicates the device may return certain > sense code/ASC/ASCQ combinations that indicate different treatment than > normal. In particular, some devices need unconditional retry (aka > ADD_TO_MLQUEUE) under certain conditions; otherwise path failures may b

Re: [PATCH v2] scsi: handle special return codes for ABORTED COMMAND

2018-02-23 Thread Douglas Gilbert
On 2018-02-23 08:33 AM, Martin Wilck wrote: Gentle reminder - reviews welcome ... On Tue, 2018-01-30 at 11:25 +0100, Martin Wilck wrote: Introduce a new blist flag that indicates the device may return certain sense code/ASC/ASCQ combinations that indicate different treatment than normal. In par

Re: [PATCH v2] scsi: handle special return codes for ABORTED COMMAND

2018-02-23 Thread Bart Van Assche
On Tue, 2018-01-30 at 11:25 +0100, Martin Wilck wrote: > Introduce a new blist flag that indicates the device may return certain > sense code/ASC/ASCQ combinations that indicate different treatment than > normal. In particular, some devices need unconditional retry (aka > ADD_TO_MLQUEUE) under cert

Re: [PATCH v2] scsi: handle special return codes for ABORTED COMMAND

2018-02-23 Thread Martin Wilck
Gentle reminder - reviews welcome ... On Tue, 2018-01-30 at 11:25 +0100, Martin Wilck wrote: > Introduce a new blist flag that indicates the device may return > certain > sense code/ASC/ASCQ combinations that indicate different treatment > than > normal. In particular, some devices need unconditio

[PATCH v2] scsi: handle special return codes for ABORTED COMMAND

2018-01-30 Thread Martin Wilck
Introduce a new blist flag that indicates the device may return certain sense code/ASC/ASCQ combinations that indicate different treatment than normal. In particular, some devices need unconditional retry (aka ADD_TO_MLQUEUE) under certain conditions; otherwise path failures may be falsely detected