Re: [PATCH v2] scsi: be2iscsi: Use kasprintf

2017-11-06 Thread Martin K. Petersen
Jitendra, >> Use kasprintf instead of combination of kmalloc and sprintf. >> Also, remove BEISCSI_MSI_NAME macro used to specify size of string as >> kasprintf handles size computations. >> >> Signed-off-by: Himanshu Jha > Reviewed-by: Jitendra Bhivare Applied to 4.15/scsi-queue. -- Martin

RE: [PATCH v2] scsi: be2iscsi: Use kasprintf

2017-11-05 Thread Jitendra Bhivare
ra...@broadcom.com; > ketan.muka...@broadcom.com; jitendra.bhiv...@broadcom.com; > Himanshu Jha > Subject: [PATCH v2] scsi: be2iscsi: Use kasprintf > > Use kasprintf instead of combination of kmalloc and sprintf. > Also, remove BEISCSI_MSI_NAME macro used to specify size of string as &

Re: [PATCH v2] scsi: be2iscsi: Use kasprintf

2017-11-03 Thread Martin K. Petersen
Himanshu, >> It is not. It needs a review/ack from the driver maintainers. > > What about Kyle Fortin's review ? Kyle's review is fine. But when a driver is actively maintained, like be2iscsi is, I always give ack/nack rights to the relevant maintainers. In this case that's Jitendra. -- Martin

Re: [PATCH v2] scsi: be2iscsi: Use kasprintf

2017-11-03 Thread Himanshu Jha
On Fri, Nov 03, 2017 at 11:25:05AM -0400, Martin K. Petersen wrote: Hi Martin, > > Himanshu, > > > Just a reminder, is my patch in our queue ? > > It is not. It needs a review/ack from the driver maintainers. What about Kyle Fortin's review ? > -- > Martin K. PetersenOracle Linux Enginee

Re: [PATCH v2] scsi: be2iscsi: Use kasprintf

2017-11-03 Thread Martin K. Petersen
Himanshu, > Just a reminder, is my patch in our queue ? It is not. It needs a review/ack from the driver maintainers. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] scsi: be2iscsi: Use kasprintf

2017-11-03 Thread Himanshu Jha
On Wed, Oct 11, 2017 at 09:06:14PM +0530, Himanshu Jha wrote: Hi James, Just a reminder, is my patch in our queue ? Thanks Himanshu Jha > Use kasprintf instead of combination of kmalloc and sprintf. > Also, remove BEISCSI_MSI_NAME macro used to specify size of string as > kasprintf handles s

Re: [PATCH v2] scsi: be2iscsi: Use kasprintf

2017-10-11 Thread Kyle Fortin
On Oct 11, 2017, at 11:36 AM, Himanshu Jha wrote: > > Use kasprintf instead of combination of kmalloc and sprintf. > Also, remove BEISCSI_MSI_NAME macro used to specify size of string as > kasprintf handles size computations. > > Signed-off-by: Himanshu Jha > --- > v2: > -remove the unnecessa

[PATCH v2] scsi: be2iscsi: Use kasprintf

2017-10-11 Thread Himanshu Jha
Use kasprintf instead of combination of kmalloc and sprintf. Also, remove BEISCSI_MSI_NAME macro used to specify size of string as kasprintf handles size computations. Signed-off-by: Himanshu Jha --- v2: -remove the unnecessary macro BEISCSI_MSI_NAME. drivers/scsi/be2iscsi/be_main.c | 12 ++