Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-06-23 Thread Arnd Bergmann
On Thursday, June 23, 2016 9:27:30 AM CEST Tomas Winkler wrote: > On Wed, Jun 22, 2016 at 3:25 PM, Arnd Bergmann wrote: > > On Wednesday, June 22, 2016 2:44:21 PM CEST Tomas Winkler wrote: > >> > > >> > There are more than 20 files that have the statement: case cpu_to_... > >> > Sparse complains a

Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-06-22 Thread Tomas Winkler
On Wed, Jun 22, 2016 at 3:25 PM, Arnd Bergmann wrote: > On Wednesday, June 22, 2016 2:44:21 PM CEST Tomas Winkler wrote: >> > >> > There are more than 20 files that have the statement: case cpu_to_... >> > Sparse complains about: case __builtin_bswap, not about >> > __builtin_constant_p. >> >> Th

Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-06-22 Thread Arnd Bergmann
On Wednesday, June 22, 2016 2:44:21 PM CEST Tomas Winkler wrote: > > > > There are more than 20 files that have the statement: case cpu_to_... > > Sparse complains about: case __builtin_bswap, not about > > __builtin_constant_p. > > There is even much more in the header files used in initializer

Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-06-22 Thread Tomas Winkler
On Wed, Jun 22, 2016 at 1:25 PM, Levy, Amir (Jer) wrote: > On 2016-06-22 Arnd Bergmann wrote: >> On Wednesday, June 22, 2016 11:24:50 AM CEST Tomas Winkler wrote: >> > On Tue, Jun 21, 2016 at 12:02 PM, Tomas Winkler >> wrote: >> > > On Tue, May 3, 2016 at 9:36 AM, Arnd Bergmann >> wrote: >> > >>

RE: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-06-22 Thread Levy, Amir (Jer)
On 2016-06-22 Arnd Bergmann wrote: > On Wednesday, June 22, 2016 11:24:50 AM CEST Tomas Winkler wrote: > > On Tue, Jun 21, 2016 at 12:02 PM, Tomas Winkler > wrote: > > > On Tue, May 3, 2016 at 9:36 AM, Arnd Bergmann > wrote: > > >> On Monday 02 May 2016 16:32:25 Andrew Morton wrote: > > > >> #i

Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-06-22 Thread Arnd Bergmann
On Wednesday, June 22, 2016 11:24:50 AM CEST Tomas Winkler wrote: > On Tue, Jun 21, 2016 at 12:02 PM, Tomas Winkler wrote: > > On Tue, May 3, 2016 at 9:36 AM, Arnd Bergmann wrote: > >> On Monday 02 May 2016 16:32:25 Andrew Morton wrote: > >> #ifdef __HAVE_BUILTIN_BSWAP32__ > >> -#define __swab3

Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-06-22 Thread Tomas Winkler
On Tue, Jun 21, 2016 at 12:02 PM, Tomas Winkler wrote: > On Tue, May 3, 2016 at 9:36 AM, Arnd Bergmann wrote: >> On Monday 02 May 2016 16:32:25 Andrew Morton wrote: >>> On Tue, 03 May 2016 01:10:16 +0200 Arnd Bergmann wrote: >>> >>> > On Monday 02 May 2016 16:02:18 Andrew Morton wrote: >>> > > O

Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-06-21 Thread Tomas Winkler
On Tue, May 3, 2016 at 9:36 AM, Arnd Bergmann wrote: > On Monday 02 May 2016 16:32:25 Andrew Morton wrote: >> On Tue, 03 May 2016 01:10:16 +0200 Arnd Bergmann wrote: >> >> > On Monday 02 May 2016 16:02:18 Andrew Morton wrote: >> > > On Mon, 02 May 2016 23:48:19 +0200 Arnd Bergmann wrote: >> > >

Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-05-02 Thread Arnd Bergmann
On Monday 02 May 2016 16:32:25 Andrew Morton wrote: > On Tue, 03 May 2016 01:10:16 +0200 Arnd Bergmann wrote: > > > On Monday 02 May 2016 16:02:18 Andrew Morton wrote: > > > On Mon, 02 May 2016 23:48:19 +0200 Arnd Bergmann wrote: > > > > > > > This is another attempt to avoid a regression in ww

Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-05-02 Thread Andrew Morton
On Tue, 03 May 2016 01:10:16 +0200 Arnd Bergmann wrote: > On Monday 02 May 2016 16:02:18 Andrew Morton wrote: > > On Mon, 02 May 2016 23:48:19 +0200 Arnd Bergmann wrote: > > > > > This is another attempt to avoid a regression in wwn_to_u64() after > > > that started using get_unaligned_be64(),

Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-05-02 Thread Arnd Bergmann
On Monday 02 May 2016 16:02:18 Andrew Morton wrote: > On Mon, 02 May 2016 23:48:19 +0200 Arnd Bergmann wrote: > > > This is another attempt to avoid a regression in wwn_to_u64() after > > that started using get_unaligned_be64(), which in turn ran into a > > bug on gcc-4.9 through 6.1. > > I'm st

Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-05-02 Thread Andrew Morton
On Mon, 02 May 2016 23:48:19 +0200 Arnd Bergmann wrote: > This is another attempt to avoid a regression in wwn_to_u64() after > that started using get_unaligned_be64(), which in turn ran into a > bug on gcc-4.9 through 6.1. I'm still getting a couple screenfuls of things like net/tipc/name_dist

[PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-05-02 Thread Arnd Bergmann
This is another attempt to avoid a regression in wwn_to_u64() after that started using get_unaligned_be64(), which in turn ran into a bug on gcc-4.9 through 6.1. The regression got introduced due to the combination of two separate workarounds (e3bde9568d99 and ef3fb2422ffe) that each try to sidest