Re: [PATCH v2] Avoid that ATA error handling can trigger a kernel hang or oops

2018-02-27 Thread Martin K. Petersen
Bart, > Avoid that the recently introduced call_rcu() call in the SCSI core > triggers a double call_rcu() call. Applied to 4.16/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] Avoid that ATA error handling can trigger a kernel hang or oops

2018-02-27 Thread Damien Le Moal
On 2018/02/27 10:53, Bart Van Assche wrote: > On Thu, 2018-02-22 at 11:30 -0800, Bart Van Assche wrote: >> Avoid that the recently introduced call_rcu() call in the SCSI core >> triggers a double call_rcu() call. >> [ ... ] > > Can anyone review this patch? Multiple users have confirmed independen

Re: [PATCH v2] Avoid that ATA error handling can trigger a kernel hang or oops

2018-02-27 Thread Bart Van Assche
On Thu, 2018-02-22 at 11:30 -0800, Bart Van Assche wrote: > Avoid that the recently introduced call_rcu() call in the SCSI core > triggers a double call_rcu() call. > [ ... ] Can anyone review this patch? Multiple users have confirmed independently that this patch fixes the double call_rcu() issue

Re: [PATCH v2] Avoid that ATA error handling can trigger a kernel hang or oops

2018-02-26 Thread Salvatore Bonaccorso
Hi, On Fri, Feb 23, 2018 at 04:46:30PM +0100, Natanael Copa wrote: > On Thu, 22 Feb 2018 11:30:20 -0800 > Bart Van Assche wrote: > > > Avoid that the recently introduced call_rcu() call in the SCSI core > > triggers a double call_rcu() call. > > This patch also prevents my machine from hanging.

Re: [PATCH v2] Avoid that ATA error handling can trigger a kernel hang or oops

2018-02-23 Thread Natanael Copa
On Thu, 22 Feb 2018 11:30:20 -0800 Bart Van Assche wrote: > Avoid that the recently introduced call_rcu() call in the SCSI core > triggers a double call_rcu() call. This patch also prevents my machine from hanging. However, the ATA error messages that I previously have had are gone, so I don't k

[PATCH v2] Avoid that ATA error handling can trigger a kernel hang or oops

2018-02-22 Thread Bart Van Assche
Avoid that the recently introduced call_rcu() call in the SCSI core triggers a double call_rcu() call. Reported-by: Natanael Copa Reported-by: Damien Le Moal References: https://bugzilla.kernel.org/show_bug.cgi?id=198861 Fixes: 3bd6f43f5cb3 ("scsi: core: Ensure that the SCSI error handler gets w