Re: [PATCH v1.2 17/16] arcmsr: fixed calling scsi_scan_host after all initialization done

2014-05-16 Thread Tomas Henzl
On 05/16/2014 01:46 PM, ching wrote: > Hi Tomas, > > Although in http://www.makelinux.net/ldd3/chp-7-sect-6, there said to flush > the shared workqueue requires calling function > flush_scheduled_work. > > But in kernel workqueue.c, there are comment of flush_scheduled_work said > that > "In mos

Re: [PATCH v1.2 17/16] arcmsr: fixed calling scsi_scan_host after all initialization done

2014-05-16 Thread ching
Hi Tomas, Although in http://www.makelinux.net/ldd3/chp-7-sect-6, there said to flush the shared workqueue requires calling function flush_scheduled_work. But in kernel workqueue.c, there are comment of flush_scheduled_work said that "In most situations flushing the entire workqueue is overkill

Re: [PATCH v1.2 17/16] arcmsr: fixed calling scsi_scan_host after all initialization done

2014-05-15 Thread Tomas Henzl
On 05/15/2014 12:49 PM, ching wrote: > Hi Tomas, > > Then I will have a patch 18/16 to replace flush_scheduled_work with > flush_work. > Thanks for your advice. Here http://www.makelinux.net/ldd3/chp-7-sect-6 is a short text about workqueue, the use of schedule_work in your sources means that you

Re: [PATCH v1.2 17/16] arcmsr: fixed calling scsi_scan_host after all initialization done

2014-05-15 Thread ching
Hi Tomas, Then I will have a patch 18/16 to replace flush_scheduled_work with flush_work. Thanks for your advice. On Wed, 2014-05-14 at 14:53 +0200, Tomas Henzl wrote: > On 05/14/2014 01:55 PM, ching wrote: > > From: Ching > > > > This is a new patch after patch v1.1 series. > > > > Fixed calling

Re: [PATCH v1.2 17/16] arcmsr: fixed calling scsi_scan_host after all initialization done

2014-05-14 Thread Tomas Henzl
On 05/14/2014 01:55 PM, ching wrote: > From: Ching > > This is a new patch after patch v1.1 series. > > Fixed calling scsi_scan_host until all initialization are done. > And fixed error path free allocated resource. > > Signed-off-by: Ching > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c >

[PATCH v1.2 17/16] arcmsr: fixed calling scsi_scan_host after all initialization done

2014-05-14 Thread ching
From: Ching This is a new patch after patch v1.1 series. Fixed calling scsi_scan_host until all initialization are done. And fixed error path free allocated resource. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arc