Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations

2015-08-20 Thread ygardi
Thank you Mita for the review. Your comments were correct and helpful. I appreciate your time and effort. please see inline. > 2015-08-16 19:14 GMT+09:00 Yaniv Gardi : >> @@ -1208,6 +1510,7 @@ static struct ufs_hba_variant_ops >> ufs_hba_qcom_vops = { >> .resume = ufs_qcom

Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations

2015-08-19 Thread Akinobu Mita
2015-08-16 19:14 GMT+09:00 Yaniv Gardi : > @@ -1208,6 +1510,7 @@ static struct ufs_hba_variant_ops ufs_hba_qcom_vops = { > .resume = ufs_qcom_resume, > .dbg_register_dump = ufs_qcom_dump_dbg_regs, > }; > +EXPORT_SYMBOL(ufs_hba_qcom_vops); As I said in the view

Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations

2015-08-18 Thread Akinobu Mita
Hi Yaniv, 2015-08-16 19:14 GMT+09:00 Yaniv Gardi : > @@ -708,17 +713,18 @@ static inline u32 > ufshcd_vops_get_ufs_hci_version(struct ufs_hba *hba) > return ufshcd_readl(hba, REG_UFS_VERSION); > } > > -static inline void ufshcd_vops_clk_scale_notify(struct ufs_hba *hba) > +static inline

[PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations

2015-08-16 Thread Yaniv Gardi
New revisions of UFS host controller supports the new UniPro hardware controller (referred as QUniPro). This patch adds the support to enable this new UniPro controller hardware. This change also adds power optimization for bus scaling feature, as well as support for HS-G3 power mode. Signed-off-