RE: [EXT] [PATCH v1 2/3] scsi: ufs: add error handling of auto-hibern8

2019-05-14 Thread Stanley Chu
Hi Bean, On Tue, 2019-05-14 at 11:14 +, Bean Huo (beanhuo) wrote: > Hi, Stanley > Thanks for reply. > > > > >On Mon, 2019-05-13 at 18:21 +, Bean Huo (beanhuo) wrote: > >> Hi, Stanley > >> > >> >+ > >> >+static inline bool ufshcd_is_auto_hibern8_error(struct ufs_hba *hba, > >> >+

RE: [EXT] [PATCH v1 2/3] scsi: ufs: add error handling of auto-hibern8

2019-05-14 Thread Bean Huo (beanhuo)
Hi, Stanley Thanks for reply. > >On Mon, 2019-05-13 at 18:21 +, Bean Huo (beanhuo) wrote: >> Hi, Stanley >> >> >+ >> >+static inline bool ufshcd_is_auto_hibern8_error(struct ufs_hba *hba, >> >+ u32 intr_mask) >> >+{ >> >+ return (ufshcd_is_auto_hiber

RE: [EXT] [PATCH v1 2/3] scsi: ufs: add error handling of auto-hibern8

2019-05-13 Thread Stanley Chu
Hi Bean, Thanks so much for review. On Mon, 2019-05-13 at 18:21 +, Bean Huo (beanhuo) wrote: > Hi, Stanley > > >+ > >+static inline bool ufshcd_is_auto_hibern8_error(struct ufs_hba *hba, > >+u32 intr_mask) > >+{ > >+return (ufshcd_is_auto_hiber

RE: [EXT] [PATCH v1 2/3] scsi: ufs: add error handling of auto-hibern8

2019-05-13 Thread Bean Huo (beanhuo)
Hi, Stanley >+ >+static inline bool ufshcd_is_auto_hibern8_error(struct ufs_hba *hba, >+ u32 intr_mask) >+{ >+ return (ufshcd_is_auto_hibern8_supported(hba) && >+ !hba->uic_async_done && Here check if uic_async_done is NULL, no big pr

[PATCH v1 2/3] scsi: ufs: add error handling of auto-hibern8

2019-05-13 Thread Stanley Chu
Currently auto-hibern8 is activated if host supports auto-hibern8 capability. However no error handlings are existed thus this feature is kind of risky. If "Hibernate Enter" or "Hibernate Exit" fail happens during auto-hibern8 flow, the corresponding interrupt "UIC_HIBERNATE_ENTER" or "UIC_HIBERNA