Re: [PATCH v1] scsi: ufs: Use explicit access size in ufshcd_dump_regs

2019-01-22 Thread Martin K. Petersen
Marc, > memcpy_fromio() doesn't provide any control over access size. > For example, on arm64, it is implemented using readb and readq. > This may trigger a synchronous external abort: Applied to 5.0/scsi-fixes, thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [RESEND PATCH v1] scsi: ufs: Use explicit access size in ufshcd_dump_regs

2019-01-22 Thread Evan Green
On Tue, Jan 22, 2019 at 9:29 AM Marc Gonzalez wrote: > > memcpy_fromio() doesn't provide any control over access size. > For example, on arm64, it is implemented using readb and readq. > This may trigger a synchronous external abort: > > [3.729943] Internal error: synchronous external abort: 9

Re: [RESEND PATCH v1] scsi: ufs: Use explicit access size in ufshcd_dump_regs

2019-01-22 Thread Greg Kroah-Hartman
On Tue, Jan 22, 2019 at 06:29:22PM +0100, Marc Gonzalez wrote: > memcpy_fromio() doesn't provide any control over access size. > For example, on arm64, it is implemented using readb and readq. > This may trigger a synchronous external abort: > > [3.729943] Internal error: synchronous external

Re: [RESEND PATCH v1] scsi: ufs: Use explicit access size in ufshcd_dump_regs

2019-01-22 Thread Bjorn Andersson
On Tue 22 Jan 09:29 PST 2019, Marc Gonzalez wrote: > memcpy_fromio() doesn't provide any control over access size. > For example, on arm64, it is implemented using readb and readq. > This may trigger a synchronous external abort: > > [3.729943] Internal error: synchronous external abort: 9600

[RESEND PATCH v1] scsi: ufs: Use explicit access size in ufshcd_dump_regs

2019-01-22 Thread Marc Gonzalez
memcpy_fromio() doesn't provide any control over access size. For example, on arm64, it is implemented using readb and readq. This may trigger a synchronous external abort: [3.729943] Internal error: synchronous external abort: 96000210 [#1] PREEMPT SMP [3.737000] Modules linked in: [

RE: [PATCH v1] scsi: ufs: Use explicit access size in ufshcd_dump_regs

2019-01-16 Thread Winkler, Tomas
> > On 09/01/2019 16:38, Jeffrey Hugo wrote: > > >> On 11/12/2018 15:18, Marc Gonzalez wrote: > >> > >>> memcpy_fromio() doesn't provide any control over access size. > >>> For example, on arm64, it is implemented using readb and readq. > >>> This may trigger a synchronous external abort: > >>> >

Re: [PATCH v1] scsi: ufs: Use explicit access size in ufshcd_dump_regs

2019-01-16 Thread Marc Gonzalez
On 09/01/2019 16:38, Jeffrey Hugo wrote: >> On 11/12/2018 15:18, Marc Gonzalez wrote: >> >>> memcpy_fromio() doesn't provide any control over access size. >>> For example, on arm64, it is implemented using readb and readq. >>> This may trigger a synchronous external abort: >>> >>> [3.729943] I

Re: [PATCH v1] scsi: ufs: Use explicit access size in ufshcd_dump_regs

2019-01-09 Thread Jeffrey Hugo
On 1/9/2019 5:42 AM, Marc Gonzalez wrote: Bjorn, Andy, Jeffrey, What do you think about the patch below? Regards. On 11/12/2018 15:18, Marc Gonzalez wrote: memcpy_fromio() doesn't provide any control over access size. For example, on arm64, it is implemented using readb and readq. This may t

Re: [PATCH v1] scsi: ufs: Use explicit access size in ufshcd_dump_regs

2019-01-09 Thread Marc Gonzalez
Bjorn, Andy, Jeffrey, What do you think about the patch below? Regards. On 11/12/2018 15:18, Marc Gonzalez wrote: > memcpy_fromio() doesn't provide any control over access size. > For example, on arm64, it is implemented using readb and readq. > This may trigger a synchronous external abort: >

Re: [PATCH v1] scsi: ufs: Use explicit access size in ufshcd_dump_regs

2018-12-27 Thread Marc Gonzalez
On 13/12/2018 23:34, Winkler, Tomas wrote: > On 11/12/2018 15:18, Marc Gonzalez wrote: > >> Fixes: ba80917d9932d ("scsi: ufs: ufshcd_dump_regs to use memcpy_fromio") >> Signed-off-by: Marc Gonzalez > > LGTM Vinayak, Joao, What do you think? Regards.

RE: [PATCH v1] scsi: ufs: Use explicit access size in ufshcd_dump_regs

2018-12-13 Thread Winkler, Tomas
> memcpy_fromio() doesn't provide any control over access size. > For example, on arm64, it is implemented using readb and readq. > This may trigger a synchronous external abort: > > [3.729943] Internal error: synchronous external abort: 96000210 [#1] > PREEMPT SMP > [3.737000] Modules l

[PATCH v1] scsi: ufs: Use explicit access size in ufshcd_dump_regs

2018-12-11 Thread Marc Gonzalez
memcpy_fromio() doesn't provide any control over access size. For example, on arm64, it is implemented using readb and readq. This may trigger a synchronous external abort: [3.729943] Internal error: synchronous external abort: 96000210 [#1] PREEMPT SMP [3.737000] Modules linked in: [