RE: [PATCH v1] scsi: mpt3sas: Use lo_hi_writeq() helper

2018-02-14 Thread Sathya Prakash Veerichetty
B; Suganath Prabu Subramani; mpt-fusionlinux@broadcom.com; Martin K. Petersen; linux-scsi@vger.kernel.org Subject: Re: [PATCH v1] scsi: mpt3sas: Use lo_hi_writeq() helper On Wed, 2018-02-14 at 21:48 +0200, Andy Shevchenko wrote: > On Wed, 2018-02-14 at 11:40 -0800, James Bottomley wr

Re: [PATCH v1] scsi: mpt3sas: Use lo_hi_writeq() helper

2018-02-14 Thread James Bottomley
On Wed, 2018-02-14 at 21:48 +0200, Andy Shevchenko wrote: > On Wed, 2018-02-14 at 11:40 -0800, James Bottomley wrote: > > > > On Wed, 2018-02-14 at 20:10 +0200, Andy Shevchenko wrote: > > > > > > Since we have a writeq() for 32-bit architectures as provided by > > > IO > > > non-atomic helpers, t

Re: [PATCH v1] scsi: mpt3sas: Use lo_hi_writeq() helper

2018-02-14 Thread Andy Shevchenko
On Wed, 2018-02-14 at 11:40 -0800, James Bottomley wrote: > On Wed, 2018-02-14 at 20:10 +0200, Andy Shevchenko wrote: > > Since we have a writeq() for 32-bit architectures as provided by IO > > non-atomic helpers, there is no need to open code it. > > > > Moreover sparse complains about this: > >

Re: [PATCH v1] scsi: mpt3sas: Use lo_hi_writeq() helper

2018-02-14 Thread James Bottomley
On Wed, 2018-02-14 at 20:10 +0200, Andy Shevchenko wrote: > Since we have a writeq() for 32-bit architectures as provided by IO > non-atomic helpers, there is no need to open code it. > > Moreover sparse complains about this: > > drivers/scsi/mpt3sas/mpt3sas_base.c:2975:16: expected unsigned long

[PATCH v1] scsi: mpt3sas: Use lo_hi_writeq() helper

2018-02-14 Thread Andy Shevchenko
Since we have a writeq() for 32-bit architectures as provided by IO non-atomic helpers, there is no need to open code it. Moreover sparse complains about this: drivers/scsi/mpt3sas/mpt3sas_base.c:2975:16: expected unsigned long long val drivers/scsi/mpt3sas/mpt3sas_base.c:2975:16: got restricted