Re: [PATCH V6 2/9] blk-mq: move cancel of requeue_work into blk_mq_release

2019-04-17 Thread Hannes Reinecke
On 4/17/19 5:44 AM, Ming Lei wrote: With holding queue's kobject refcount, it is safe for driver to schedule requeue. However, blk_mq_kick_requeue_list() may be called after blk_sync_queue() is done because of concurrent requeue activities, then requeue work may not be completed when freeing queu

[PATCH V6 2/9] blk-mq: move cancel of requeue_work into blk_mq_release

2019-04-16 Thread Ming Lei
With holding queue's kobject refcount, it is safe for driver to schedule requeue. However, blk_mq_kick_requeue_list() may be called after blk_sync_queue() is done because of concurrent requeue activities, then requeue work may not be completed when freeing queue, and kernel oops is triggered. So m