Re: [PATCH V6 10/18] scsi: ufs: manually add well known logical units

2014-10-05 Thread Akinobu Mita
2014-10-04 1:35 GMT+09:00 Christoph Hellwig : > On Sat, Oct 04, 2014 at 01:16:16AM +0900, Akinobu Mita wrote: >> These __scsi_add_device() calls for W-LUs increase the module reference >> count of ufshcd.ko by three. But no one calls scsi_device_put() for >> these W-LUs, so it is impossible to unl

Re: [PATCH V6 10/18] scsi: ufs: manually add well known logical units

2014-10-03 Thread Christoph Hellwig
On Sat, Oct 04, 2014 at 01:16:16AM +0900, Akinobu Mita wrote: > These __scsi_add_device() calls for W-LUs increase the module reference > count of ufshcd.ko by three. But no one calls scsi_device_put() for > these W-LUs, so it is impossible to unload ufshcd.ko. > > There are scsi_remove_device()

RE: [PATCH V6 10/18] scsi: ufs: manually add well known logical units

2014-10-03 Thread Subhash Jadavani
t: Friday, October 03, 2014 9:16 AM To: Dolev Raviv Cc: Jej B; Christoph Hellwig; linux-scsi@vger.kernel.org; linux-scsi-ow...@vger.kernel.org; linux-arm-...@vger.kernel.org; Santosh Y; Subhash Jadavani Subject: Re: [PATCH V6 10/18] scsi: ufs: manually add well known logical units 2014-09-25 21:32

Re: [PATCH V6 10/18] scsi: ufs: manually add well known logical units

2014-10-03 Thread Akinobu Mita
2014-09-25 21:32 GMT+09:00 Dolev Raviv : > +static int ufshcd_scsi_add_wlus(struct ufs_hba *hba) > +{ > + int ret = 0; > + > + hba->sdev_ufs_device = __scsi_add_device(hba->host, 0, 0, > + ufshcd_upiu_wlun_to_scsi_wlun(UFS_UPIU_UFS_DEVICE_WLUN), > NULL); > + if (IS

[PATCH V6 10/18] scsi: ufs: manually add well known logical units

2014-09-25 Thread Dolev Raviv
From: Subhash Jadavani UFS device specification requires the UFS devices to support 4 well known logical units: "REPORT_LUNS" (address: 01h) "UFS Device" (address: 50h) "RPMB" (address: 44h) "BOOT" (address: 30h) UFS device's power management needs to be controlle