Re: [PATCH V5 5/7] blk-mq-sched: move actual dispatching into one helper

2017-10-09 Thread Ming Lei
On Mon, Oct 02, 2017 at 07:19:56AM -0700, Christoph Hellwig wrote: > Can you move this to the beginning of your series, just after > the other edits to blk_mq_sched_dispatch_requests? OK. > > > +static void blk_mq_do_dispatch_sched(struct request_queue *q, > > +st

Re: [PATCH V5 5/7] blk-mq-sched: move actual dispatching into one helper

2017-10-02 Thread Christoph Hellwig
Can you move this to the beginning of your series, just after the other edits to blk_mq_sched_dispatch_requests? > +static void blk_mq_do_dispatch_sched(struct request_queue *q, > + struct elevator_queue *e, > + struct blk_mq_hw_ctx

[PATCH V5 5/7] blk-mq-sched: move actual dispatching into one helper

2017-09-30 Thread Ming Lei
So that it becomes easy to support to dispatch from sw queue in the following patch. No functional change. Reviewed-by: Bart Van Assche Reviewed-by: Omar Sandoval Tested-by: Oleksandr Natalenko Tested-by: Tom Nguyen Tested-by: Paolo Valente Signed-off-by: Ming Lei --- block/blk-mq-sched.c