Re: [PATCH V5 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2013-01-16 Thread vinayak holikatti
On Fri, Jan 11, 2013 at 6:00 PM, Subhash Jadavani wrote: > On 1/11/2013 4:11 PM, Sujit Reddy Thumma wrote: >> >> On 1/9/2013 5:41 PM, vinayak holikatti wrote: >>> >>> On Mon, Jan 7, 2013 at 1:11 PM, Sujit Reddy Thumma >>> wrote: Hi Vinayak, I have few comments below:

Re: [PATCH V5 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2013-01-11 Thread Subhash Jadavani
On 1/11/2013 4:11 PM, Sujit Reddy Thumma wrote: On 1/9/2013 5:41 PM, vinayak holikatti wrote: On Mon, Jan 7, 2013 at 1:11 PM, Sujit Reddy Thumma wrote: Hi Vinayak, I have few comments below: +#ifdef CONFIG_PM +/** + * ufshcd_pltfrm_suspend - suspend power management function + * @pdev: poi

Re: [PATCH V5 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2013-01-11 Thread Sujit Reddy Thumma
On 1/9/2013 5:41 PM, vinayak holikatti wrote: On Mon, Jan 7, 2013 at 1:11 PM, Sujit Reddy Thumma wrote: Hi Vinayak, I have few comments below: +#ifdef CONFIG_PM +/** + * ufshcd_pltfrm_suspend - suspend power management function + * @pdev: pointer to Platform device handle + * @mesg: power s

Re: [PATCH V5 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2013-01-09 Thread vinayak holikatti
On Mon, Jan 7, 2013 at 1:11 PM, Sujit Reddy Thumma wrote: > Hi Vinayak, > > I have few comments below: > > > +#ifdef CONFIG_PM > +/** > + * ufshcd_pltfrm_suspend - suspend power management function > + * @pdev: pointer to Platform device handle > + * @mesg: power state > +

Re: [PATCH V5 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2013-01-06 Thread Sujit Reddy Thumma
Hi Vinayak, I have few comments below: +#ifdef CONFIG_PM +/** + * ufshcd_pltfrm_suspend - suspend power management function + * @pdev: pointer to Platform device handle + * @mesg: power state + * + * Returns -ENOSYS What breaks if you return 0 instead of retu

Re: [PATCH V5 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2013-01-06 Thread Subhash Jadavani
On 1/4/2013 1:07 PM, vinayak holikatti wrote: On Thu, Dec 27, 2012 at 8:28 PM, Subhash Jadavani wrote: On 12/27/2012 1:45 AM, vinholika...@gmail.com wrote: From: Vinayak Holikatti This patch adds Platform glue driver for ufshcd. Reviewed-by: Arnd Bergmann Reviewed-by: Namjae Jeon Signed-o

Re: [PATCH V5 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2013-01-03 Thread vinayak holikatti
On Thu, Dec 27, 2012 at 8:28 PM, Subhash Jadavani wrote: > On 12/27/2012 1:45 AM, vinholika...@gmail.com wrote: >> >> From: Vinayak Holikatti >> >> This patch adds Platform glue driver for ufshcd. >> >> Reviewed-by: Arnd Bergmann >> Reviewed-by: Namjae Jeon >> Signed-off-by: Vinayak Holikatti

Re: [PATCH V5 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2012-12-27 Thread Subhash Jadavani
On 12/27/2012 1:45 AM, vinholika...@gmail.com wrote: From: Vinayak Holikatti This patch adds Platform glue driver for ufshcd. Reviewed-by: Arnd Bergmann Reviewed-by: Namjae Jeon Signed-off-by: Vinayak Holikatti Signed-off-by: Santosh Yaraganavi --- drivers/scsi/ufs/Kconfig | 11

[PATCH V5 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2012-12-26 Thread vinholikatti
From: Vinayak Holikatti This patch adds Platform glue driver for ufshcd. Reviewed-by: Arnd Bergmann Reviewed-by: Namjae Jeon Signed-off-by: Vinayak Holikatti Signed-off-by: Santosh Yaraganavi --- drivers/scsi/ufs/Kconfig | 11 ++ drivers/scsi/ufs/Makefile|1 + drivers/