Re: [PATCH V2 00/12] scsi-mq support for ZBC disks

2017-09-13 Thread Damien Le Moal
Christoph, On 9/14/17 05:17, Christoph Hellwig wrote: > On Tue, Sep 12, 2017 at 05:38:05PM +0900, Damien Le Moal wrote: >> struct blk_zoned { >> unsigned int nr_zones; >> unsigned long *seq_zones; >> }; >> >> struct request_queue { >> ... >> #ifdef CONFIG_BLK_DEV_ZONED >> struc

Re: [PATCH V2 00/12] scsi-mq support for ZBC disks

2017-09-13 Thread Christoph Hellwig
On Tue, Sep 12, 2017 at 05:38:05PM +0900, Damien Le Moal wrote: > struct blk_zoned { > unsigned int nr_zones; > unsigned long *seq_zones; > }; > > struct request_queue { > ... > #ifdef CONFIG_BLK_DEV_ZONED > struct blk_zoned zoned; > #endif > ... Do we even need a ne

Re: [PATCH V2 00/12] scsi-mq support for ZBC disks

2017-09-12 Thread Damien Le Moal
Christoph, On 9/11/17 21:24, Christoph Hellwig wrote: > On Fri, Sep 08, 2017 at 09:12:12AM -0700, Damien Le Moal wrote: >> 1) The zone size and the number of zones of the device (for the bitmaps >> allocation and offset->zone number conversion). >> 2) Zone type for the optimization that avoids loc

Re: [PATCH V2 00/12] scsi-mq support for ZBC disks

2017-09-11 Thread Christoph Hellwig
On Fri, Sep 08, 2017 at 09:12:12AM -0700, Damien Le Moal wrote: > 1) The zone size and the number of zones of the device (for the bitmaps > allocation and offset->zone number conversion). > 2) Zone type for the optimization that avoids locking conventional zones. > > (2) is optional. We can do wit

Re: [PATCH V2 00/12] scsi-mq support for ZBC disks

2017-09-08 Thread Damien Le Moal
Christoph, On 9/8/17 01:20, Christoph Hellwig wrote: > I'm really worried about how this is tied into the sd driver. > > From a quick look it seems like the only thing you really need in > the scheduler that is done through struct scsi_disk is the > offset + len -> zone number lookup - I'd much r

Re: [PATCH V2 00/12] scsi-mq support for ZBC disks

2017-09-08 Thread Christoph Hellwig
I'm really worried about how this is tied into the sd driver. >From a quick look it seems like the only thing you really need in the scheduler that is done through struct scsi_disk is the offset + len -> zone number lookup - I'd much rather expose this from sd upwards and keep the scheduler in the

[PATCH V2 00/12] scsi-mq support for ZBC disks

2017-09-07 Thread Damien Le Moal
This series implements support for ZBC disks used through the scsi-mq I/O path. The current scsi level support of ZBC disks guarantees write request ordering using a per-zone write lock which prevents issuing simultaneously multiple write commands to a zone, doing so avoid reordering of sequential