Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now

2018-09-20 Thread Martin K. Petersen
Adrian, > blk-mq does not support runtime pm, so disable blk-mq support for now. Applied to 4.19/scsi-fixes. Looking forward to getting this fixed up properly in 4.20. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now

2018-09-19 Thread Christoph Hellwig
On Fri, Sep 14, 2018 at 09:52:38AM +0800, Ming Lei wrote: > However, in previous discussion, it is strongly objected to use > per-driver/device .use_blk_mq switch, so not sure if this way can > be accepted. I don't like the per-driver switch as module_parameter at all and we should never do that.

Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now

2018-09-14 Thread Adrian Hunter
On 14/09/18 09:17, Adrian Hunter wrote: > On 14/09/18 04:52, Ming Lei wrote: >> On Thu, Sep 13, 2018 at 03:15:39PM +0300, Adrian Hunter wrote: >>> On 13/09/18 15:05, Ming Lei wrote: On Thu, Sep 13, 2018 at 02:28:48PM +0300, Adrian Hunter wrote: > blk-mq does not support runtime pm, so disa

Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now

2018-09-13 Thread Adrian Hunter
On 14/09/18 04:52, Ming Lei wrote: > On Thu, Sep 13, 2018 at 03:15:39PM +0300, Adrian Hunter wrote: >> On 13/09/18 15:05, Ming Lei wrote: >>> On Thu, Sep 13, 2018 at 02:28:48PM +0300, Adrian Hunter wrote: blk-mq does not support runtime pm, so disable blk-mq support for now. >>> >>> So could y

Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now

2018-09-13 Thread Ming Lei
On Thu, Sep 13, 2018 at 03:15:39PM +0300, Adrian Hunter wrote: > On 13/09/18 15:05, Ming Lei wrote: > > On Thu, Sep 13, 2018 at 02:28:48PM +0300, Adrian Hunter wrote: > >> blk-mq does not support runtime pm, so disable blk-mq support for now. > > > > So could you describe a bit what the issue you

Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now

2018-09-13 Thread Adrian Hunter
On 13/09/18 15:05, Ming Lei wrote: > On Thu, Sep 13, 2018 at 02:28:48PM +0300, Adrian Hunter wrote: >> blk-mq does not support runtime pm, so disable blk-mq support for now. > > So could you describe a bit what the issue you are trying to fix? UFS is a low-power solution, so we must be able to ru

Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now

2018-09-13 Thread Ming Lei
On Thu, Sep 13, 2018 at 02:28:48PM +0300, Adrian Hunter wrote: > blk-mq does not support runtime pm, so disable blk-mq support for now. So could you describe a bit what the issue you are trying to fix? This is host level runtime PM you are trying to address, and if blk-mq runtime isn't enabled, I

[PATCH RFC] scsi: ufs: Disable blk-mq for now

2018-09-13 Thread Adrian Hunter
blk-mq does not support runtime pm, so disable blk-mq support for now. Fixes: d5038a13eca7 ("scsi: core: switch to scsi-mq by default") Signed-off-by: Adrian Hunter --- drivers/scsi/ufs/ufshcd.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/u