RE: [PATCH 6/8] bsg-lib: handle bidi requests without block layer help

2018-11-19 Thread Avri Altman
-scsi@vger.kernel.org; linux- > bl...@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: [PATCH 6/8] bsg-lib: handle bidi requests without block layer help > > We can just stash away the second request in struct bsg_job instead > of using the block layer req->next_rq field, all

Re: [PATCH 6/8] bsg-lib: handle bidi requests without block layer help

2018-11-14 Thread Benjamin Block
On Wed, Nov 14, 2018 at 04:48:57PM +0100, Christoph Hellwig wrote: > On Tue, Nov 13, 2018 at 03:35:20PM +0100, Benjamin Block wrote: > > This seems like a non-obvious user-breakage. So apart from removing the > > in-kernel stuff that uses bidirectional commands you also forbid > > userspace from ev

Re: [PATCH 6/8] bsg-lib: handle bidi requests without block layer help

2018-11-14 Thread Christoph Hellwig
On Tue, Nov 13, 2018 at 03:35:20PM +0100, Benjamin Block wrote: > This seems like a non-obvious user-breakage. So apart from removing the > in-kernel stuff that uses bidirectional commands you also forbid > userspace from every using them? That seems wrong to me. > > There is other SCSI Command Se

Re: [PATCH 6/8] bsg-lib: handle bidi requests without block layer help

2018-11-13 Thread Benjamin Block
On Sun, Nov 11, 2018 at 02:32:09PM +0100, Christoph Hellwig wrote: > We can just stash away the second request in struct bsg_job instead > of using the block layer req->next_rq field, allowing for the eventual > removal of the latter. > > Signed-off-by: Christoph Hellwig > --- > block/bsg-lib.c

[PATCH 6/8] bsg-lib: handle bidi requests without block layer help

2018-11-11 Thread Christoph Hellwig
We can just stash away the second request in struct bsg_job instead of using the block layer req->next_rq field, allowing for the eventual removal of the latter. Signed-off-by: Christoph Hellwig --- block/bsg-lib.c | 44 +++--- block/bsg.c