Re: [PATCH 6/6] scsi: remove a useless get/put_device pair in scsi_requeue_command

2014-02-12 Thread Christoph Hellwig
On Wed, Feb 12, 2014 at 12:40:24PM +0100, Hannes Reinecke wrote: > On 02/06/2014 07:43 PM, Christoph Hellwig wrote: > > Avoid a spurious device get/put cycle by using scsi_put_command and folding > > scsi_unprep_request into scsi_requeue_command. > > > > Signed-off-by: Christoph Hellwig > Makes o

Re: [PATCH 6/6] scsi: remove a useless get/put_device pair in scsi_requeue_command

2014-02-12 Thread Hannes Reinecke
On 02/06/2014 07:43 PM, Christoph Hellwig wrote: > Avoid a spurious device get/put cycle by using scsi_put_command and folding > scsi_unprep_request into scsi_requeue_command. > > Signed-off-by: Christoph Hellwig Makes one wonder why we didn't do this to start with. Acked-by: Hannes Reinecke C

[PATCH 6/6] scsi: remove a useless get/put_device pair in scsi_requeue_command

2014-02-06 Thread Christoph Hellwig
Avoid a spurious device get/put cycle by using scsi_put_command and folding scsi_unprep_request into scsi_requeue_command. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_lib.c | 35 +++ 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/drive