Re: [PATCH 6/21] advansys: Move to scsi hotplug initialisation model

2007-07-26 Thread Jeff Garzik
Matthew Wilcox wrote: @@ -18511,13 +18493,24 @@ advansys_board_found(int iop, struct device *dev, int bus_type) } if (err_code != 0) - goto err_free_irq; + goto err_free_wide_mem; ASC_DBG_PRT_SCSI_HOST(2, shost); + ret = scsi_add_host(shost, dev);

Re: [PATCH 6/21] advansys: Move to scsi hotplug initialisation model

2007-07-26 Thread Matthew Wilcox
On Thu, Jul 26, 2007 at 02:16:27PM -0400, Jeff Garzik wrote: > In that case, reverse what I said: the above pci_register_driver commit > breaks non-PCI probing. Ah yes. Fair point. > advansys_detect/release populate legacy list, but nothing ever happens > from there... your "Move to scsi hot

Re: [PATCH 6/21] advansys: Move to scsi hotplug initialisation model

2007-07-26 Thread Matthew Wilcox
On Thu, Jul 26, 2007 at 12:04:46PM -0600, Matthew Wilcox wrote: > That happened in patch 4. The function that looks for ISA and VL is still > called advansys_detect, but I can rename it to advansys_probe_legacy if > you want. Um. That's patch 4/22 ... or patch 3/21. I knew I should have used gi

Re: [PATCH 6/21] advansys: Move to scsi hotplug initialisation model

2007-07-26 Thread Jeff Garzik
Matthew Wilcox wrote: On Thu, Jul 26, 2007 at 12:04:46PM -0600, Matthew Wilcox wrote: That happened in patch 4. The function that looks for ISA and VL is still called advansys_detect, but I can rename it to advansys_probe_legacy if you want. git-format-patch's --start-number option. This pa

Re: [PATCH 6/21] advansys: Move to scsi hotplug initialisation model

2007-07-26 Thread Jeff Garzik
Matthew Wilcox wrote: On Thu, Jul 26, 2007 at 07:01:12PM +0100, Christoph Hellwig wrote: On Thu, Jul 26, 2007 at 01:22:42PM -0400, Matthew Wilcox wrote: - Switch from scsi_register/scsi_unregister to scsi_host_alloc, scsi_add_host, scsi_scan_host and scsi_host_put. - Rename the scsi_host_t

Re: [PATCH 6/21] advansys: Move to scsi hotplug initialisation model

2007-07-26 Thread Matthew Wilcox
On Thu, Jul 26, 2007 at 07:01:12PM +0100, Christoph Hellwig wrote: > On Thu, Jul 26, 2007 at 01:22:42PM -0400, Matthew Wilcox wrote: > > - Switch from scsi_register/scsi_unregister to scsi_host_alloc, > >scsi_add_host, scsi_scan_host and scsi_host_put. > > - Rename the scsi_host_template to a

Re: [PATCH 6/21] advansys: Move to scsi hotplug initialisation model

2007-07-26 Thread Christoph Hellwig
On Thu, Jul 26, 2007 at 01:22:42PM -0400, Matthew Wilcox wrote: > - Switch from scsi_register/scsi_unregister to scsi_host_alloc, >scsi_add_host, scsi_scan_host and scsi_host_put. > - Rename the scsi_host_template to advansys_template > - Move the memory freeing on error from advansys_wide_i

[PATCH 6/21] advansys: Move to scsi hotplug initialisation model

2007-07-26 Thread Matthew Wilcox
- Switch from scsi_register/scsi_unregister to scsi_host_alloc, scsi_add_host, scsi_scan_host and scsi_host_put. - Rename the scsi_host_template to advansys_template - Move the memory freeing on error from advansys_wide_init_chip() back into advansys_board_found() as we need to free it if