Re: [PATCH 5/7] ahci: Convert driver to use modern PM hooks

2016-02-18 Thread Christoph Hellwig
On Thu, Feb 18, 2016 at 08:12:46AM -0500, Tejun Heo wrote: > On Thu, Feb 18, 2016 at 12:45:05PM +0200, Andy Shevchenko wrote: > > > + .driver.pm = &ahci_pci_pm_ops, > > > > Please, do this in several assignments, since to support older compilers. > > Can you please elaborate?

Re: [PATCH 5/7] ahci: Convert driver to use modern PM hooks

2016-02-18 Thread Tejun Heo
On Thu, Feb 18, 2016 at 12:45:05PM +0200, Andy Shevchenko wrote: > > + .driver.pm = &ahci_pci_pm_ops, > > Please, do this in several assignments, since to support older compilers. Can you please elaborate? That's a single assignment. Are there compilers which can't do that?

Re: [PATCH 5/7] ahci: Convert driver to use modern PM hooks

2016-02-18 Thread Andy Shevchenko
On Thu, Feb 18, 2016 at 10:54 AM, Mika Westerberg wrote: > In order to add support for runtime PM to the ahci driver we first need to > convert the driver to use modern non-legacy system suspend hooks. There > should be no functional changes. > One comment below, otherwise: Reviewed-by: Andy Shev

[PATCH 5/7] ahci: Convert driver to use modern PM hooks

2016-02-18 Thread Mika Westerberg
In order to add support for runtime PM to the ahci driver we first need to convert the driver to use modern non-legacy system suspend hooks. There should be no functional changes. Signed-off-by: Mika Westerberg --- drivers/ata/ahci.c | 49 ++--- 1 file