On Mon, 15 Oct 2018, Hannes Reinecke wrote:
> On 10/13/18 2:51 AM, Finn Thain wrote:
> > As a temporary measure, the code to implement PIO transfers was
> > duplicated in zorro_esp and mac_esp. Now that this code has stabilized,
> > move it into the core driver to eliminate the duplication.
> >
On 10/13/18 2:51 AM, Finn Thain wrote:
As a temporary measure, the code to implement PIO transfers was
duplicated in zorro_esp and mac_esp. Now that this code has stabilized,
move it into the core driver to eliminate the duplication.
This replaces the inline assembler with more portable writesb(
On Sat, Oct 13, 2018 at 06:22:18PM +1100, Finn Thain wrote:
> > > + pr_err("FIFO is empty (sreg %02x)\n", esp_read8(ESP_STATUS));
> >
> > This should probably use dev_err (at least with my series).
> >
>
> How about shost_printk()? That would be consistent with the rest of
> esp_scsi.c. It also
On Sat, 13 Oct 2018, Christoph Hellwig wrote:
> > +#if IS_ENABLED(CONFIG_SCSI_MAC_ESP) || IS_ENABLED(CONFIG_SCSI_ZORRO_ESP)
>
> Please add a new CONFIG_SCSI_ESP_PIO symbol that is selected by
> the mac and zorro drivers instead.
>
OK.
> > + pr_err("FIFO is empty (sreg %02x)\n", esp_read8(ESP
> +#if IS_ENABLED(CONFIG_SCSI_MAC_ESP) || IS_ENABLED(CONFIG_SCSI_ZORRO_ESP)
Please add a new CONFIG_SCSI_ESP_PIO symbol that is selected by
the mac and zorro drivers instead.
> + pr_err("FIFO is empty (sreg %02x)\n", esp_read8(ESP_STATUS));
This should probably use dev_err (at least with my
As a temporary measure, the code to implement PIO transfers was
duplicated in zorro_esp and mac_esp. Now that this code has stabilized,
move it into the core driver to eliminate the duplication.
This replaces the inline assembler with more portable writesb() calls.
Optimizing the m68k writesb() im
6 matches
Mail list logo
