Re: [PATCH 4/5] Do an agent reset on error recovery.

2007-04-11 Thread Stefan Richter
Kristian Høgsberg wrote: > On 4/11/07, Stefan Richter <[EMAIL PROTECTED]> wrote: > Forget the "host bus adapters" which are mentioned in Linux SCSI core. >> What are meant there are cards which connect SCSI Parallel Interconnect >> with a local bus. > > Or maybe more generally bridge chipsets that

Re: [PATCH 4/5] Do an agent reset on error recovery.

2007-04-11 Thread Stefan Richter
Kristian Høgsberg wrote: [hostt->eh_ flavors] > The reason I made this change was that I was looking at sbp2.c, at the > way it handles cancellation looks wrong to me. It implements both > abort_handler and device_reset, but the only command it sends to the > device in either case it an agent rese

Re: [PATCH 4/5] Do an agent reset on error recovery.

2007-04-10 Thread Stefan Richter
I wrote: > Kristian Høgsberg wrote: >> Also, implement the .eh_host_reset_handler callback instead of >> .eh_abort_handler since that's what we're actually doing. > > You reset the target port (or specifically, the fetch agent acting on > that target port). But the .eh_host_reset_handler is to "a

Re: [PATCH 4/5] Do an agent reset on error recovery.

2007-04-10 Thread Stefan Richter
(added Cc: LSML) Kristian Høgsberg wrote: > Also, implement the .eh_host_reset_handler callback instead of > .eh_abort_handler since that's what we're actually doing. You reset the target port (or specifically, the fetch agent acting on that target port). But the .eh_host_reset_handler is to "as