Re: [PATCH 33/36] scsi: Add 'access_state' attribute

2015-10-01 Thread Bart Van Assche
On 09/29/2015 03:47 AM, Hannes Reinecke wrote: +static const struct { + enum scsi_access_state value; + char*name; Had you considered to use "const char *" here instead of "char *" ? +const char *scsi_access_state_name(enum scsi_access_state state) +{ +

Re: [PATCH 33/36] scsi: Add 'access_state' attribute

2015-09-29 Thread kbuild test robot
Hi Hannes, [auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore] reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/scsi/scsi_sysfs.c:98:12: sparse: symbol 's

[PATCH 33/36] scsi: Add 'access_state' attribute

2015-09-29 Thread Hannes Reinecke
Add an 'access_state' attribute to struct scsi_device to display the asymmetric LUN access state. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_scan.c | 1 + drivers/scsi/scsi_sysfs.c | 49 ++ include/scsi/scsi_device.h | 1 + include/scsi/