Re: [PATCH 3/4] scsi: add Mylex RAID controller

2017-08-09 Thread Hannes Reinecke
On 08/09/2017 04:10 PM, Christoph Hellwig wrote: > On Mon, Aug 07, 2017 at 08:09:11AM +0200, Hannes Reinecke wrote: >> On 08/05/2017 01:39 PM, Christoph Hellwig wrote: >>> Can you use normal linux style for the code instead of copy and >>> pasting the weird naming and capitalization from the DAC960

Re: [PATCH 3/4] scsi: add Mylex RAID controller

2017-08-09 Thread Christoph Hellwig
On Mon, Aug 07, 2017 at 08:09:11AM +0200, Hannes Reinecke wrote: > On 08/05/2017 01:39 PM, Christoph Hellwig wrote: > > Can you use normal linux style for the code instead of copy and > > pasting the weird naming and capitalization from the DAC960 driver? > > > Yes; already planned for v2. But fir

Re: [PATCH 3/4] scsi: add Mylex RAID controller

2017-08-06 Thread Hannes Reinecke
On 08/05/2017 01:39 PM, Christoph Hellwig wrote: > Can you use normal linux style for the code instead of copy and > pasting the weird naming and capitalization from the DAC960 driver? > Yes; already planned for v2. But first wanted to get some general feedback (like: is anyone interested in that

Re: [PATCH 3/4] scsi: add Mylex RAID controller

2017-08-05 Thread Christoph Hellwig
Can you use normal linux style for the code instead of copy and pasting the weird naming and capitalization from the DAC960 driver? Also please use the driver name as prefix for the functions. Maybe myraid instead of mylex? I'll take a more detailed look at the actual driver in a bit.