Re: [PATCH 3/3] target: Change some fabric functions to return bool

2014-11-17 Thread Andy Grover
On 11/13/2014 11:06 PM, Christoph Hellwig wrote: On Thu, Nov 13, 2014 at 12:50:58PM -0800, Andy Grover wrote: The tpg_check_* functions in the fabric_ops struct return 1 or 0, so we can make their return type bool. Change fabrics to match. All these true/false stub sounds like some of them met

Re: [PATCH 3/3] target: Change some fabric functions to return bool

2014-11-13 Thread Christoph Hellwig
On Thu, Nov 13, 2014 at 12:50:58PM -0800, Andy Grover wrote: > The tpg_check_* functions in the fabric_ops struct return 1 or 0, > so we can make their return type bool. Change fabrics to match. All these true/false stub sounds like some of them methods should be optional, and a useful default sho

[PATCH 3/3] target: Change some fabric functions to return bool

2014-11-13 Thread Andy Grover
The tpg_check_* functions in the fabric_ops struct return 1 or 0, so we can make their return type bool. Change fabrics to match. Signed-off-by: Andy Grover --- drivers/infiniband/ulp/srpt/ib_srpt.c| 8 drivers/scsi/qla2xxx/tcm_qla2xxx.c | 10 +- drivers/targe