Re: [PATCH 3/3] scsi: move the writeable from struct scsi_device to struct scsi_cd

2014-07-21 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> We currently set the field in common code based on the device Christoph> type, but then only use it in the cdrom driver which also Christoph> overrides the value previously set in the generic code. Christoph> Just leave this entirely to t

Re: [PATCH 3/3] scsi: move the writeable from struct scsi_device to struct scsi_cd

2014-07-20 Thread Hannes Reinecke
On 07/18/2014 05:17 PM, Christoph Hellwig wrote: We currently set the field in common code based on the device type, but then only use it in the cdrom driver which also overrides the value previously set in the generic code. Just leave this entirely to the CDROM driver to make everyones life sim

[PATCH 3/3] scsi: move the writeable from struct scsi_device to struct scsi_cd

2014-07-18 Thread Christoph Hellwig
We currently set the field in common code based on the device type, but then only use it in the cdrom driver which also overrides the value previously set in the generic code. Just leave this entirely to the CDROM driver to make everyones life simpler. Signed-off-by: Christoph Hellwig --- drive