Re: [PATCH 3/3] block: add back command filter modification via sysfs

2018-11-16 Thread Bart Van Assche
On Fri, 2018-11-16 at 08:00 +0100, Paolo Bonzini wrote: > On 16/11/18 06:46, Bart Van Assche wrote: > > I do not know any application for which it would be useful to allow some but > > not all of these commands. With the proposed interface however users will > > have to examine all SCSI opcodes and

Re: [PATCH 3/3] block: add back command filter modification via sysfs

2018-11-15 Thread Paolo Bonzini
On 16/11/18 06:46, Bart Van Assche wrote: > I do not know any application for which it would be useful to allow some but > not all of these commands. With the proposed interface however users will > have to examine all SCSI opcodes and for each opcode they will have to decide > whether or not it sh

Re: [PATCH 3/3] block: add back command filter modification via sysfs

2018-11-15 Thread Bart Van Assche
On Sat, 2018-11-10 at 17:35 +0100, Paolo Bonzini wrote: > +sgio_read_filter (RW) > +- > +When read, this file will display a list of SCSI commands (i.e. values of > +the first byte of a CDB) that are always available for unprivileged users > +via /dev/bsg, /dev/sgNN, or ioctls s

[PATCH 3/3] block: add back command filter modification via sysfs

2018-11-10 Thread Paolo Bonzini
This adds two new sysfs attributes to the queue kobject. The attributes allow reading and writing the whitelist of unprivileged commands. This is again a bit different from what was removed in commit 018e044 (block: get rid of queue-private command filter, 2009-06-26), but the idea is the same.

Re: [PATCH 3/3] block: add back command filter modification via sysfs

2012-09-12 Thread Paolo Bonzini
Il 12/09/2012 14:41, Alan Cox ha scritto: >> > + if (!q->cmd_filter) { >> > + q->cmd_filter = kmalloc(sizeof(struct blk_cmd_filter), >> > + GFP_KERNEL); >> > + blk_set_cmd_filter_defaults(q->cmd_filter); >> > + } >> > + > This also needs CAP_SYS_

Re: [PATCH 3/3] block: add back command filter modification via sysfs

2012-09-12 Thread Alan Cox
> +ssize_t blk_filter_store(struct request_queue *q, > + const char *page, size_t count, int rw) > +{ > + unsigned long okbits[BLK_SCSI_CMD_PER_LONG], *target_okbits; > + bool set; > + const char *p = page; > + char *endp; > + int start = -1, cmd; > + > +

Re: [PATCH 3/3] block: add back command filter modification via sysfs

2012-09-12 Thread Alan Cox
O > + if (!q->cmd_filter) { > + q->cmd_filter = kmalloc(sizeof(struct blk_cmd_filter), > + GFP_KERNEL); > + blk_set_cmd_filter_defaults(q->cmd_filter); Out of memory - memset - oops -- To unsubscribe from this list: send the line "uns

[PATCH 3/3] block: add back command filter modification via sysfs

2012-09-12 Thread Paolo Bonzini
This adds two new sysfs attributes to the queue kobject. The attributes allow reading and writing the whitelist of unprivileged commands. This is again a bit different from what was removed in commit 018e044 (block: get rid of queue-private command filter, 2009-06-26), but the idea is the same.