Re: [PATCH 23/29] atari_scsi: Convert to platform device

2014-10-26 Thread Finn Thain
On Sun, 26 Oct 2014, Michael Schmitz wrote: > > On Mon, 20 Oct 2014, Michael Schmitz wrote: > > > > > not certain it is related to this exact patch - the driver crashes > > > pretty much on the spot when selecting the first target on the bus. > > > > > ... > > Turns out I missed a reject i

Re: [PATCH 23/29] atari_scsi: Convert to platform device

2014-10-26 Thread Michael Schmitz
Finn, On Mon, 20 Oct 2014, Michael Schmitz wrote: Hi Finn, not certain it is related to this exact patch - the driver crashes pretty much on the spot when selecting the first target on the bus. If it isn't that exact patch then it will probably be one of the other atari_scsi patche

Re: [PATCH 23/29] atari_scsi: Convert to platform device

2014-10-20 Thread Michael Schmitz
Hi Finn, >> not certain it is related to this exact patch - the driver crashes >> pretty much on the spot when selecting the first target on the bus. > > If it isn't that exact patch then it will probably be one of the other > atari_scsi patches. Most of the other relevant stuff was covered by my

Re: [PATCH 23/29] atari_scsi: Convert to platform device

2014-10-20 Thread Finn Thain
On Mon, 20 Oct 2014, Michael Schmitz wrote: > Hi Finn, > > not certain it is related to this exact patch - the driver crashes > pretty much on the spot when selecting the first target on the bus. If it isn't that exact patch then it will probably be one of the other atari_scsi patches. Most o

Re: [PATCH 23/29] atari_scsi: Convert to platform device

2014-10-20 Thread Michael Schmitz
Hi Finn, not certain it is related to this exact patch - the driver crashes pretty much on the spot when selecting the first target on the bus. Panic log: Atari SCSI: resetting the SCSI bus... done scsi host0: Atari native SCSI, io_port 0x0, n_io_port 0, base 0x0, irq 0, can_queue 8, cmd_per_

Re: [PATCH 23/29] atari_scsi: Convert to platform device

2014-10-08 Thread Finn Thain
On Mon, 6 Oct 2014, Michael Schmitz wrote: > > > > > Can these be handled through the platform_device's resources? > > > > > > > > I don't know. > > > > > > Should be possible - I've seen that used in the ISP116x HCD driver > > > (arch-dependent post-register access delay function passed via

Re: [PATCH 23/29] atari_scsi: Convert to platform device

2014-10-06 Thread Geert Uytterhoeven
On Mon, Oct 6, 2014 at 9:05 AM, Finn Thain wrote: >> > > > + if (IS_A_TT()) >> > > > + instance->irq = IRQ_TT_MFP_SCSI; >> > > > + else >> > > > + instance->irq = IRQ_NONE; >> > > > >> > > platform_device resource? >> > > >> > >> > If I thought it possible t

Re: [PATCH 23/29] atari_scsi: Convert to platform device

2014-10-06 Thread Michael Schmitz
Hi Finn, Can these be handled through the platform_device's resources? I don't know. Should be possible - I've seen that used in the ISP116x HCD driver (arch-dependent post-register access delay function passed via platform data). Yes, possible, but is it desir

Re: [PATCH 23/29] atari_scsi: Convert to platform device

2014-10-06 Thread Finn Thain
On Sun, 5 Oct 2014, Michael Schmitz wrote: > > On Fri, 3 Oct 2014, Geert Uytterhoeven wrote: > > > > > > > > + if (ATARIHW_PRESENT(TT_SCSI)) { > > > > + atari_scsi_reg_read = atari_scsi_tt_reg_read; > > > > + atari_scsi_reg_write = atari_scsi_tt_reg_write; >

Re: [PATCH 23/29] atari_scsi: Convert to platform device

2014-10-04 Thread Michael Schmitz
Finn, On Fri, 3 Oct 2014, Geert Uytterhoeven wrote: + if (ATARIHW_PRESENT(TT_SCSI)) { + atari_scsi_reg_read = atari_scsi_tt_reg_read; + atari_scsi_reg_write = atari_scsi_tt_reg_write; + } else if (ATARIHW_PRESENT(ST_SCSI)) { + atari_scsi

Re: [PATCH 23/29] atari_scsi: Convert to platform device

2014-10-03 Thread Finn Thain
On Fri, 3 Oct 2014, Geert Uytterhoeven wrote: > > + if (ATARIHW_PRESENT(TT_SCSI)) { > > + atari_scsi_reg_read = atari_scsi_tt_reg_read; > > + atari_scsi_reg_write = atari_scsi_tt_reg_write; > > + } else if (ATARIHW_PRESENT(ST_SCSI)) { > > + a

Re: [PATCH 23/29] atari_scsi: Convert to platform device

2014-10-03 Thread Geert Uytterhoeven
On Thu, Oct 2, 2014 at 8:56 AM, Finn Thain wrote: > Convert atari_scsi to platform device and eliminate scsi_register(). > > Validate __setup options later on so that module options are checked as well. > > Remove the comment about the scsi mid-layer disabling the host irq as it > is no longer tru

[PATCH 23/29] atari_scsi: Convert to platform device

2014-10-02 Thread Finn Thain
Convert atari_scsi to platform device and eliminate scsi_register(). Validate __setup options later on so that module options are checked as well. Remove the comment about the scsi mid-layer disabling the host irq as it is no longer true (AFAICT). Also remove the obsolete slow interrupt stuff (IR