Re: [PATCH 22/23] zfcp: drop default switch case which might paper over missing case

2018-11-22 Thread Steffen Maier
On 11/16/2018 12:22 PM, Hannes Reinecke wrote: On 11/8/18 3:44 PM, Steffen Maier wrote: would now suppress helpful -Wswitch compiler warnings when building with W=1 But then again, only with W=1 we would notice unhandled enum cases. that's the only caveat Without the default cases and a

Re: [PATCH 22/23] zfcp: drop default switch case which might paper over missing case

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: This was introduced with v4.18 commit 8c3d20aada70 ("scsi: zfcp: fix missing REC trigger trace for all objects in ERP_FAILED") but would now suppress helpful -Wswitch compiler warnings when building with W=1 such as the following forced example: drivers/s

[PATCH 22/23] zfcp: drop default switch case which might paper over missing case

2018-11-08 Thread Steffen Maier
This was introduced with v4.18 commit 8c3d20aada70 ("scsi: zfcp: fix missing REC trigger trace for all objects in ERP_FAILED") but would now suppress helpful -Wswitch compiler warnings when building with W=1 such as the following forced example: drivers/s390/scsi/zfcp_erp.c: In function 'zfcp_erp_