RE: [PATCH 21/29] scsi: aacraid: Refactor resolve luns code and scsi functions

2017-12-26 Thread Raghava Aditya Renukunta
inux Driver ; > gpicc...@linux.vnet.ibm.com; Tom White ; > Scott Benesh > Subject: Re: [PATCH 21/29] scsi: aacraid: Refactor resolve luns code and scsi > functions > > EXTERNAL EMAIL > > > On Thu, 2017-12-21 at 09:34 -0800, Raghava Aditya Renukunta wrote: > > +

Re: [PATCH 21/29] scsi: aacraid: Refactor resolve luns code and scsi functions

2017-12-21 Thread Bart Van Assche
On Thu, 2017-12-21 at 09:34 -0800, Raghava Aditya Renukunta wrote: > + if (bus == CONTAINER_CHANNEL) > + bus = CONTAINER_CHANNEL; Sorry but I don't see how the above code can be useful? Thanks, Bart.

[PATCH 21/29] scsi: aacraid: Refactor resolve luns code and scsi functions

2017-12-21 Thread Raghava Aditya Renukunta
Resolve luns checks the if a sdev is already present in the os to figure out if it needs to be removed. Internally the driver exposes HBA on bus 2 even though its bus 1 in the fw. Its mildly confusing. Refactor out the sdev lookup into its function to check if sdev has been added to the kernel or