Re: [PATCH 21/26] scsi: simplify scsi_log_(send|completion)

2014-10-15 Thread Hannes Reinecke
Subject: [PATCH 21/26] scsi: simplify scsi_log_(send|completion) Simplify scsi_log_(send|completion) by externalizing scsi_mlreturn_string() and always print the command address. ... diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index b853659..2df485f 100644 --- a/drivers/scsi

RE: [PATCH 21/26] scsi: simplify scsi_log_(send|completion)

2014-10-08 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Tuesday, 07 October, 2014 4:03 AM > To: James Bottomley > Cc: Christoph Hellwig; linux-scsi@vger.kernel.org; Elliott, Robert (Server > Storage); Hannes Reinecke > Subject: [PATCH 21/26] scsi: si

[PATCH 21/26] scsi: simplify scsi_log_(send|completion)

2014-10-07 Thread Hannes Reinecke
Simplify scsi_log_(send|completion) by externalizing scsi_mlreturn_string() and always print the command address. Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/constants.c | 41 ++--- drivers/scsi/

Re: [PATCH 21/26] scsi: simplify scsi_log_(send|completion)

2014-10-07 Thread Hannes Reinecke
On 10/06/2014 09:53 PM, Ewan Milne wrote: > Rats. I found another case of "(null)" appearing in the log messages > where I think you really just wanted no text at all to appear. > Sorry I didn't find it last time along with the other one... > Nae bother. I'll be sending a new version of the patch

Re: [PATCH 21/26] scsi: simplify scsi_log_(send|completion)

2014-10-06 Thread Ewan Milne
Rats. I found another case of "(null)" appearing in the log messages where I think you really just wanted no text at all to appear. Sorry I didn't find it last time along with the other one... -Ewan On Mon, 2014-10-06 at 11:01 +0200, Hannes Reinecke wrote: > Simplify scsi_log_(send|completion) b

[PATCH 21/26] scsi: simplify scsi_log_(send|completion)

2014-10-06 Thread Hannes Reinecke
Simplify scsi_log_(send|completion) by externalizing scsi_mlreturn_string() and always print the command address. Reviewed-by: Robert Elliott Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/constants.c | 39 --- drivers/scsi/sc