Re: [PATCH 21/21] advansys: use memcpy instead of open-coded loop

2007-07-26 Thread Matthew Wilcox
On Thu, Jul 26, 2007 at 03:50:45PM -0400, Jeff Garzik wrote: > Done with my review. Any patches I did not comment on can be considered > sane... Thanks, Jeff, that was a Herculean effort. I've gone through and made most of your suggested changes. I'm making too many mistakes now, so it's time

Re: [PATCH 21/21] advansys: use memcpy instead of open-coded loop

2007-07-26 Thread Jeff Garzik
Done with my review. Any patches I did not comment on can be considered sane... - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 21/21] advansys: use memcpy instead of open-coded loop

2007-07-26 Thread Matthew Wilcox
Use memcpy to initialise eep_config instead of a loop. For AdvInitFrom38C1600EEP where we need to modify the default EEPROM configuration, do it after the loop, and do it using the structure definition, not by finding the right byte. I think it was wrong for big-endian machines. Also delete some