Re: [PATCH 20/22] scsi: align logging messages

2014-09-19 Thread Hannes Reinecke
On 09/19/2014 01:35 PM, Christoph Hellwig wrote: On Fri, Sep 19, 2014 at 08:26:29AM +0200, Hannes Reinecke wrote: I would rather use 'scmd->tag', as this should be a straight copy of scmd->request->tag, but we wouldn't need to reference the request when doing so. Yes, for now scmd->tag is corr

Re: [PATCH 20/22] scsi: align logging messages

2014-09-19 Thread Christoph Hellwig
On Fri, Sep 19, 2014 at 08:26:29AM +0200, Hannes Reinecke wrote: > I would rather use 'scmd->tag', as this should be a straight copy > of scmd->request->tag, but we wouldn't need to reference the request > when doing so. Yes, for now scmd->tag is correct as drivers might not be using the block lev

Re: [PATCH 20/22] scsi: align logging messages

2014-09-18 Thread Hannes Reinecke
On 09/19/2014 01:58 AM, Elliott, Robert (Server Storage) wrote: -Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] ... scmd ties the messages together so you can tell which command has gotten to which state. grep works. Can we just print the tag instead, that w

RE: [PATCH 20/22] scsi: align logging messages

2014-09-18 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] ... > > scmd ties the messages together so you can tell which command > > has gotten to which state. grep works. > > Can we just print the tag instead, that would be a much more human > readable number normally.

Re: [PATCH 20/22] scsi: align logging messages

2014-09-05 Thread Christoph Hellwig
On Mon, Sep 01, 2014 at 01:00:26AM +, Elliott, Robert (Server Storage) wrote: > > -Original Message- > > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > > ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > > Sent: Sunday, 31 August, 2014 5:26 PM > ... > > On Thu, Aug

RE: [PATCH 20/22] scsi: align logging messages

2014-08-31 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Sunday, 31 August, 2014 5:26 PM ... > On Thu, Aug 28, 2014 at 07:33:34PM +0200, Hannes Reinecke wrote: > > Always use 'scmd 0x%p' when logging

Re: [PATCH 20/22] scsi: align logging messages

2014-08-31 Thread Christoph Hellwig
On Thu, Aug 28, 2014 at 07:33:34PM +0200, Hannes Reinecke wrote: > Always use 'scmd 0x%p' when logging a command pointer. Is there any good reason to print the address of a command pointer? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord

[PATCH 20/22] scsi: align logging messages

2014-08-28 Thread Hannes Reinecke
Always use 'scmd 0x%p' when logging a command pointer. Suggested-by: Robert Elliot Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi.c | 7 +++--- drivers/scsi/scsi_error.c | 58 +++ drivers/scsi/scsi_lib.c | 2 +- 3 files changed, 34 ins