Re: [PATCH 20/20] scsi_error: format abort error message

2014-09-14 Thread Christoph Hellwig
On Sat, Sep 13, 2014 at 01:07:11AM +, Elliott, Robert (Server Storage) wrote: > > I've not seen an answer to my question in reply to the previous version > > of this. Why would you do pretty printing of a variable that can just > > return SUCCESS or FAILURE? > > Is there anything prohibiting

Re: [PATCH 20/20] scsi_error: format abort error message

2014-09-14 Thread Hannes Reinecke
On 09/13/2014 03:07 AM, Elliott, Robert (Server Storage) wrote: -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Christoph Hellwig Sent: Friday, 05 September, 2014 7:33 PM Subject: Re: [PATCH 20/20] scsi_error: format abort

RE: [PATCH 20/20] scsi_error: format abort error message

2014-09-12 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Friday, 05 September, 2014 7:33 PM > Subject: Re: [PATCH 20/20] scsi_error: format abort error message > > On Wed, Sep 0

Re: [PATCH 20/20] scsi_error: format abort error message

2014-09-05 Thread Christoph Hellwig
On Wed, Sep 03, 2014 at 12:06:15PM +0200, Hannes Reinecke wrote: > Decode the return value if the command abort failed. I've not seen an answer to my question in reply to the previous version of this. Why would you do pretty printing of a variable that can just return SUCCESS or FAILURE? -- To u

Re: [PATCH 20/20] scsi_error: format abort error message

2014-09-04 Thread Yoshihiro YUNOMAE
(2014/09/03 19:06), Hannes Reinecke wrote: > Decode the return value if the command abort failed. > > Suggested-by: Robert Elliot > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/scsi_error.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/scsi_

[PATCH 20/20] scsi_error: format abort error message

2014-09-03 Thread Hannes Reinecke
Decode the return value if the command abort failed. Suggested-by: Robert Elliot Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_error.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index 8a6d382..eca63b2 1006