Re: [PATCH 2.4.30-pre3] x86_64: pci_alloc_consistent() match 2.6 implementation

2005-03-22 Thread Siddha, Suresh B
On Sat, Mar 19, 2005 at 04:17:51PM -0600, Matt Domsch wrote: > OK, then how's this for review? Compiles clean, can't test it myself > for a few days. > > - int high = 0, mmu; > - if (((unsigned long)virt_to_bus(memory) + size) > 0xUL) > - high =

Re: [PATCH 2.4.30-pre3] x86_64: pci_alloc_consistent() match 2.6 implementation

2005-03-19 Thread Matt Domsch
On Sat, Mar 19, 2005 at 08:26:45PM +0100, Andi Kleen wrote: > On Fri, Mar 18, 2005 at 03:23:44PM -0600, Matt Domsch wrote: > > For review and comment. > > > > On x86_64 systems with no IOMMU and with >4GB RAM (in fact, whenever > > there are any pages mapped above 4GB), pci_alloc_consistent() fall

Re: [PATCH 2.4.30-pre3] x86_64: pci_alloc_consistent() match 2.6 implementation

2005-03-19 Thread Andi Kleen
On Fri, Mar 18, 2005 at 03:23:44PM -0600, Matt Domsch wrote: > For review and comment. > > On x86_64 systems with no IOMMU and with >4GB RAM (in fact, whenever > there are any pages mapped above 4GB), pci_alloc_consistent() falls > back to using ZONE_DMA for all allocations, even if the device's >

Re: [PATCH 2.4.30-pre3] x86_64: pci_alloc_consistent() match 2.6 implementation

2005-03-19 Thread Arjan van de Ven
On Sat, 2005-03-19 at 08:16 -0600, Matt Domsch wrote: > On Sat, Mar 19, 2005 at 07:09:45AM +0100, Arjan van de Ven wrote: > > On Fri, 2005-03-18 at 15:23 -0600, Matt Domsch wrote: > > > For review and comment. > > > > > > On x86_64 systems with no IOMMU and with >4GB RAM (in fact, whenever > > > t

Re: [PATCH 2.4.30-pre3] x86_64: pci_alloc_consistent() match 2.6 implementation

2005-03-19 Thread Matt Domsch
On Sat, Mar 19, 2005 at 07:09:45AM +0100, Arjan van de Ven wrote: > On Fri, 2005-03-18 at 15:23 -0600, Matt Domsch wrote: > > For review and comment. > > > > On x86_64 systems with no IOMMU and with >4GB RAM (in fact, whenever > > there are any pages mapped above 4GB), pci_alloc_consistent() falls

Re: [PATCH 2.4.30-pre3] x86_64: pci_alloc_consistent() match 2.6 implementation

2005-03-18 Thread Arjan van de Ven
On Fri, 2005-03-18 at 15:23 -0600, Matt Domsch wrote: > For review and comment. > > On x86_64 systems with no IOMMU and with >4GB RAM (in fact, whenever > there are any pages mapped above 4GB), pci_alloc_consistent() falls > back to using ZONE_DMA for all allocations, even if the device's > dma_ma

[PATCH 2.4.30-pre3] x86_64: pci_alloc_consistent() match 2.6 implementation

2005-03-18 Thread Matt Domsch
For review and comment. On x86_64 systems with no IOMMU and with >4GB RAM (in fact, whenever there are any pages mapped above 4GB), pci_alloc_consistent() falls back to using ZONE_DMA for all allocations, even if the device's dma_mask could have supported using memory from other zones. Problems c