Re: [PATCH 2/5] scsi: libsas: check the lldd callback correctly

2018-09-17 Thread Hannes Reinecke
On 09/12/2018 10:29 AM, Jason Yan wrote: > We are using lldd_port_deformed so we'd better check if lldd_port_deformed > is NULL. > > After this, we can remove hisi_sas_port_deformed() because it is just a > stub to avoid a NULL dereference caused by the wrong check. > > Signed-off-by: Jason Yan

Re: [PATCH 2/5] scsi: libsas: check the lldd callback correctly

2018-09-17 Thread John Garry
On 12/09/2018 09:29, Jason Yan wrote: We are using lldd_port_deformed so we'd better check if lldd_port_deformed is NULL. After this, we can remove hisi_sas_port_deformed() because it is just a stub to avoid a NULL dereference caused by the wrong check. Signed-off-by: Jason Yan Acked-by: Joh

[PATCH 2/5] scsi: libsas: check the lldd callback correctly

2018-09-12 Thread Jason Yan
We are using lldd_port_deformed so we'd better check if lldd_port_deformed is NULL. After this, we can remove hisi_sas_port_deformed() because it is just a stub to avoid a NULL dereference caused by the wrong check. Signed-off-by: Jason Yan CC: John Garry CC: Johannes Thumshirn CC: Ewan Milne