Re: [PATCH 2/4] tcm_qla2xxx: T10-Dif set harware capability

2014-04-02 Thread sagi grimberg
On 4/1/2014 8:40 PM, Nicholas A. Bellinger wrote: So no way to get it centralized? Yes, still working on how that might look.. I still don't understand the iscsi/iser constraint. Every other fabric aside from iscsi/iser could simply provide a TFO->get_fabric_prot(se_tpg) to query for supp

Re: [PATCH 2/4] tcm_qla2xxx: T10-Dif set harware capability

2014-04-01 Thread Nicholas A. Bellinger
On Tue, 2014-04-01 at 11:04 +0300, Sagi Grimberg wrote: > On 4/1/2014 4:11 AM, Nicholas A. Bellinger wrote: > > + > +if (scsi_host_get_prot(lport->qla_vha->host)) { > +tpg->se_tpg.fabric_sup_prot_type = (TARGET_DIF_TYPE0_PROT| > +TARGET_DIF_T

Re: [PATCH 2/4] tcm_qla2xxx: T10-Dif set harware capability

2014-04-01 Thread Sagi Grimberg
On 4/1/2014 4:11 AM, Nicholas A. Bellinger wrote: + +if (scsi_host_get_prot(lport->qla_vha->host)) { +tpg->se_tpg.fabric_sup_prot_type = (TARGET_DIF_TYPE0_PROT| +TARGET_DIF_TYPE1_PROT|TARGET_DIF_TYPE2_PROT| +TARGET_DIF_TYPE3_PROT); + +

Re: [PATCH 2/4] tcm_qla2xxx: T10-Dif set harware capability

2014-03-31 Thread Nicholas A. Bellinger
On Mon, 2014-03-31 at 15:38 +, Quinn Tran wrote: > On 3/28/14 5:12 PM, "sagi grimberg" wrote: > > >On 3/29/2014 2:05 AM, Quinn Tran wrote: > >> Set Protection Type(1,2,3) capabilities, Guarg type (CRC/IPchksm) > >> capabilities bits to let TCM core knows of HW/fabric capabilities. > >> > >>

Re: [PATCH 2/4] tcm_qla2xxx: T10-Dif set harware capability

2014-03-31 Thread Quinn Tran
Regards, Quinn Tran On 3/28/14 5:12 PM, "sagi grimberg" wrote: >On 3/29/2014 2:05 AM, Quinn Tran wrote: >> Set Protection Type(1,2,3) capabilities, Guarg type (CRC/IPchksm) >> capabilities bits to let TCM core knows of HW/fabric capabilities. >> >> Signed-off-by: Nicholas Bellinger >> Signe

Re: [PATCH 2/4] tcm_qla2xxx: T10-Dif set harware capability

2014-03-28 Thread sagi grimberg
On 3/29/2014 2:05 AM, Quinn Tran wrote: Set Protection Type(1,2,3) capabilities, Guarg type (CRC/IPchksm) capabilities bits to let TCM core knows of HW/fabric capabilities. Signed-off-by: Nicholas Bellinger Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 23

[PATCH 2/4] tcm_qla2xxx: T10-Dif set harware capability

2014-03-28 Thread Quinn Tran
Set Protection Type(1,2,3) capabilities, Guarg type (CRC/IPchksm) capabilities bits to let TCM core knows of HW/fabric capabilities. Signed-off-by: Nicholas Bellinger Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 23 +++ drivers/scsi/qla2xxx/tcm_q