Re: [PATCH 2/4] block layer varlen-cdb

2007-11-05 Thread Boaz Harrosh
On Fri, Nov 02 2007 at 13:17 +0200, Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Fri, Nov 02, 2007 at 08:32:12AM +0200, Benny Halevy wrote: >> I agree this is probably the cleanest implementation but when Boaz and I >> initially discussed this approach he convinced me that LL block devices >> as

Re: [PATCH 2/4] block layer varlen-cdb

2007-11-02 Thread Matthew Wilcox
On Fri, Nov 02, 2007 at 08:32:12AM +0200, Benny Halevy wrote: > I agree this is probably the cleanest implementation but when Boaz and I > initially discussed this approach he convinced me that LL block devices assume > that req->cmd_len <= BLK_MAX_CDB and it is unsafe at the moment to expose them

Re: [PATCH 2/4] block layer varlen-cdb

2007-11-01 Thread Benny Halevy
On Nov. 01, 2007, 20:40 +0200, Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Thu, Nov 01, 2007 at 08:05:06PM +0200, Boaz Harrosh wrote: >> @@ -287,8 +287,13 @@ struct request { >> /* >> * when request is used as a packet command carrier >> */ >> -unsigned int cmd_len; >> +

Re: [PATCH 2/4] block layer varlen-cdb

2007-11-01 Thread Matthew Wilcox
On Thu, Nov 01, 2007 at 08:05:06PM +0200, Boaz Harrosh wrote: > @@ -287,8 +287,13 @@ struct request { > /* >* when request is used as a packet command carrier >*/ > - unsigned int cmd_len; > + unsigned short cmd_len; > + unsigned short varlen_cdb_len; /* length of

[PATCH 2/4] block layer varlen-cdb

2007-11-01 Thread Boaz Harrosh
- add varlen_cdb and varlen_cdb_len to hold a large user cdb if needed. They start as empty. Allocation of buffer must be done by user and held until request execution is done. Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- block/ll_rw_blk.c |2 ++ include/linux/blkdev.h