Re: [PATCH 2/2] zfcp: zfcp: add statistics and other zfcp relatedinformation to sysfs

2007-09-08 Thread Heiko Carstens
>> +dev_set_drvdata(&adapter->stat_services, adapter); >> + >> +if (device_register(&adapter->stat_services)) >> +goto services_failed; >> + >> +if (zfcp_sysfs_statistic_services_create_files(&adapter->stat_services)) >> +{ >> +device_unregister(&adapter->sta

Re: [PATCH 2/2] zfcp: zfcp: add statistics and other zfcp relatedinformation to sysfs

2007-09-07 Thread Martin Peschke
I am afraid this patch can't be applied as it is. The problem is that the code doesn't take into account that older adapters do not provide the data which your patch tries to extract. There is a feature flag for that in the hardware specification. So the right response to Heiko's complaint abo

[PATCH 2/2] zfcp: zfcp: add statistics and other zfcp relatedinformation to sysfs

2007-09-07 Thread Swen Schillig
From: Swen Schillig <[EMAIL PROTECTED]> add statistics and other zfcp related information to sysfs The zfcp adapter provides a variety of information which was never published to the external world. This patch adds a few of those "statistics" to the sysfs tree structure. These are reflected in t