Re: [PATCH 2/2] virtio_scsi: support multi hw queue of blk-mq

2014-11-11 Thread Paolo Bonzini
On 10/11/2014 17:05, Christoph Hellwig wrote: > > a) there is no multiath support for it, and we simply can't break existing > setups that use. > b) there is no support for I/O schedulers at all. This might be okay > for virtio-scsi, where in general you have a host scheduler, but for

Re: [PATCH 2/2] virtio_scsi: support multi hw queue of blk-mq

2014-11-10 Thread Christoph Hellwig
On Mon, Nov 10, 2014 at 10:25:43PM +0800, Ming Lei wrote: > It depends on how long the transition period is, and other drivers > with multi hwq support might be in the same situation with virtio-scsi. If > the period is a bit long, it would be painful for these drivers to support > both blk-mq and

Re: [PATCH 2/2] virtio_scsi: support multi hw queue of blk-mq

2014-11-10 Thread Ming Lei
On Mon, Nov 10, 2014 at 9:39 PM, Christoph Hellwig wrote: > On Mon, Nov 10, 2014 at 11:41:43AM +0100, Paolo Bonzini wrote: >> FWIW, instead of force_blk_mq, it would be fine for me to make >> virtio-scsi use a single queue if not using blk-mq. > > I agree with that. For virtio-scsi, we can do tha

Re: [PATCH 2/2] virtio_scsi: support multi hw queue of blk-mq

2014-11-10 Thread Christoph Hellwig
On Mon, Nov 10, 2014 at 11:41:43AM +0100, Paolo Bonzini wrote: > FWIW, instead of force_blk_mq, it would be fine for me to make > virtio-scsi use a single queue if not using blk-mq. I agree with that. I'd rather move all of SCSI over after a fairly short period instead of special cases like this,

Re: [PATCH 2/2] virtio_scsi: support multi hw queue of blk-mq

2014-11-10 Thread Paolo Bonzini
On 09/11/2014 17:57, Ming Lei wrote: > Since virtio_scsi has supported multi virtqueue already, > it is natural to map virtque to hw-queue of blk-mq. > > Cc: Paolo Bonzini > Signed-off-by: Ming Lei > --- > drivers/scsi/virtio_scsi.c | 154 > > 1 fi

[PATCH 2/2] virtio_scsi: support multi hw queue of blk-mq

2014-11-09 Thread Ming Lei
Since virtio_scsi has supported multi virtqueue already, it is natural to map virtque to hw-queue of blk-mq. Cc: Paolo Bonzini Signed-off-by: Ming Lei --- drivers/scsi/virtio_scsi.c | 154 1 file changed, 14 insertions(+), 140 deletions(-) diff --g