Re: [PATCH 2/2] uas: Make uas work with blk-mq

2014-10-03 Thread Hans de Goede
Hi, On 10/03/2014 10:47 AM, Christoph Hellwig wrote: > On Thu, Oct 02, 2014 at 09:25:50AM -0400, James Bottomley wrote: >> OK, so 3.17 should be on sunday giving three days or so to sort this >> out. If you're happy with blk-mq being disabled so the bug never >> triggers unless the user activates

Re: [PATCH 2/2] uas: Make uas work with blk-mq

2014-10-03 Thread Christoph Hellwig
On Thu, Oct 02, 2014 at 09:25:50AM -0400, James Bottomley wrote: > OK, so 3.17 should be on sunday giving three days or so to sort this > out. If you're happy with blk-mq being disabled so the bug never > triggers unless the user activates it, doing nothing is my preferred > outcome ... but that a

Re: [PATCH 2/2] uas: Make uas work with blk-mq

2014-10-02 Thread Greg Kroah-Hartman
On Thu, Oct 02, 2014 at 06:12:59AM -0700, Christoph Hellwig wrote: > On Thu, Oct 02, 2014 at 03:08:40PM +0200, Hans de Goede wrote: > > Yes, although that likely would need to go through stable, without > > going into 3.18 . > > > > Greg, is this ok with you and how do I get a patch in stable whic

Re: [PATCH 2/2] uas: Make uas work with blk-mq

2014-10-02 Thread Hans de Goede
Hi, On 10/02/2014 03:25 PM, James Bottomley wrote: > On Thu, 2014-10-02 at 15:18 +0200, Hans de Goede wrote: >> Hi, >> >> On 10/02/2014 03:12 PM, Christoph Hellwig wrote: >>> On Thu, Oct 02, 2014 at 03:08:40PM +0200, Hans de Goede wrote: Yes, although that likely would need to go through stab

Re: [PATCH 2/2] uas: Make uas work with blk-mq

2014-10-02 Thread James Bottomley
On Thu, 2014-10-02 at 15:18 +0200, Hans de Goede wrote: > Hi, > > On 10/02/2014 03:12 PM, Christoph Hellwig wrote: > > On Thu, Oct 02, 2014 at 03:08:40PM +0200, Hans de Goede wrote: > >> Yes, although that likely would need to go through stable, without > >> going into 3.18 . > >> > >> Greg, is th

Re: [PATCH 2/2] uas: Make uas work with blk-mq

2014-10-02 Thread Hans de Goede
Hi, On 10/02/2014 03:12 PM, Christoph Hellwig wrote: > On Thu, Oct 02, 2014 at 03:08:40PM +0200, Hans de Goede wrote: >> Yes, although that likely would need to go through stable, without >> going into 3.18 . >> >> Greg, is this ok with you and how do I get a patch in stable which >> is not in ups

Re: [PATCH 2/2] uas: Make uas work with blk-mq

2014-10-02 Thread Christoph Hellwig
On Thu, Oct 02, 2014 at 03:08:40PM +0200, Hans de Goede wrote: > Yes, although that likely would need to go through stable, without > going into 3.18 . > > Greg, is this ok with you and how do I get a patch in stable which > is not in upstream (because upstream will get a better fix) ? This is a

Re: [PATCH 2/2] uas: Make uas work with blk-mq

2014-10-02 Thread Hans de Goede
Hi, On 10/02/2014 03:06 PM, Christoph Hellwig wrote: > On Thu, Oct 02, 2014 at 02:35:10PM +0200, Hans de Goede wrote: >> This patch sits on top of a whole bunch of uas cleanups / fixes which >> are going into 3.18, and which are to big of a change to backport. > > Can add a patch to set disable_b

Re: [PATCH 2/2] uas: Make uas work with blk-mq

2014-10-02 Thread Christoph Hellwig
On Thu, Oct 02, 2014 at 02:35:10PM +0200, Hans de Goede wrote: > This patch sits on top of a whole bunch of uas cleanups / fixes which > are going into 3.18, and which are to big of a change to backport. Can add a patch to set disable_blk_mq for uas on 3.17 then? -- To unsubscribe from this list:

Re: [PATCH 2/2] uas: Make uas work with blk-mq

2014-10-02 Thread Hans de Goede
Hi, On 10/02/2014 01:26 PM, Christoph Hellwig wrote: > Looks fine to me (and actually removes code..) > > Reviewed-by: Christoph Hellwig > > It's fairly late in 3.17 to get something like this in, but would you > consider Ccing it to stable so we can get it into the first 3.17 stable > release?

Re: [PATCH 2/2] uas: Make uas work with blk-mq

2014-10-02 Thread Christoph Hellwig
Looks fine to me (and actually removes code..) Reviewed-by: Christoph Hellwig It's fairly late in 3.17 to get something like this in, but would you consider Ccing it to stable so we can get it into the first 3.17 stable release? -- To unsubscribe from this list: send the line "unsubscribe linux-

[PATCH 2/2] uas: Make uas work with blk-mq

2014-10-02 Thread Hans de Goede
With uas over usb-3 the tags inside the uas iu-s must match the usb-3 stream ids, and those go from 1 - qdepth. Before blk-mq calling scsi_activate_tcq(sdev, qdepth) guaranteed that we would only get cmnd->request->tag from 0 - (qdepth - 1), and we used those as uas-tags / stream-ids. With blk-mq