Re: [PATCH 2/2] scsi_dh_alua: Fix a recently introduced deadlock

2016-03-29 Thread Ewan D. Milne
On Mon, 2016-03-28 at 11:14 -0700, Bart Van Assche wrote: > While retesting the SRP initiator I ran the command "rmmod mlx4_ib" > while I/O was in progress. That command triggers SCSI device removal > indirectly. Avoid that this action triggers the following deadlock: > > =

Re: [PATCH 2/2] scsi_dh_alua: Fix a recently introduced deadlock

2016-03-29 Thread Christoph Hellwig
This indeed looks like the only place where we took pg->lock without disabling irqs. Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kerne

Re: [PATCH 2/2] scsi_dh_alua: Fix a recently introduced deadlock

2016-03-28 Thread Hannes Reinecke
On 03/28/2016 08:14 PM, Bart Van Assche wrote: > While retesting the SRP initiator I ran the command "rmmod mlx4_ib" > while I/O was in progress. That command triggers SCSI device removal > indirectly. Avoid that this action triggers the following deadlock: > > = >

Re: [PATCH 2/2] scsi_dh_alua: Fix a recently introduced deadlock

2016-03-28 Thread Laurence Oberman
Message - From: "Bart Van Assche" To: "James Bottomley" , "Martin K. Petersen" Cc: "Hannes Reinecke" , "Christoph Hellwig" , linux-scsi@vger.kernel.org Sent: Monday, March 28, 2016 2:14:04 PM Subject: [PATCH 2/2] scsi_dh_alua: Fix a rec

[PATCH 2/2] scsi_dh_alua: Fix a recently introduced deadlock

2016-03-28 Thread Bart Van Assche
While retesting the SRP initiator I ran the command "rmmod mlx4_ib" while I/O was in progress. That command triggers SCSI device removal indirectly. Avoid that this action triggers the following deadlock: = [ INFO: inconsistent lock state ] 4.6.0-rc0-dbg+ #2 Tainted