Re: [PATCH 2/2] qla2xxx: Avoid that issuing a LIP triggers a kernel crash

2017-01-25 Thread Mauricio Faria de Oliveira
Hi Martin, On 01/25/2017 09:29 PM, Martin K. Petersen wrote: Please do a proper patch submission for this fix. Okay, I submitted a v2 patch w/ the suggested change. However, the original patch has been submitted by Bart, so I believe credit is due, but not sure how to handle this case. Thus,

Re: [PATCH 2/2] qla2xxx: Avoid that issuing a LIP triggers a kernel crash

2017-01-25 Thread Martin K. Petersen
> "Mauricio" == Mauricio Faria de Oliveira > writes: Hi Mauricio, Mauricio> First of all, sorry for the new bug; I didn't realize the Mauricio> pointer could be NULL at this scenario. Please do a proper patch submission for this fix. -- Martin K. Petersen Oracle Linux Engineerin

Re: [PATCH 2/2] qla2xxx: Avoid that issuing a LIP triggers a kernel crash

2017-01-25 Thread Madhani, Himanshu
On 1/24/17, 6:59 AM, "Mauricio Faria de Oliveira" wrote: >Hi Bart, > >First of all, sorry for the new bug; I didn't realize the pointer could >be NULL at this scenario. > >On 01/23/2017 02:34 PM, Bart Van Assche wrote: >> @@ -1624,7 +1627,8 @@ qla2x00_abort_all_cmds(scsi_qla_host_t *vha, int r

Re: [PATCH 2/2] qla2xxx: Avoid that issuing a LIP triggers a kernel crash

2017-01-24 Thread Mauricio Faria de Oliveira
Hi Bart, First of all, sorry for the new bug; I didn't realize the pointer could be NULL at this scenario. On 01/23/2017 02:34 PM, Bart Van Assche wrote: @@ -1624,7 +1627,8 @@ qla2x00_abort_all_cmds(scsi_qla_host_t *vha, int res) */

Re: [PATCH 2/2] qla2xxx: Avoid that issuing a LIP triggers a kernel crash

2017-01-24 Thread Johannes Thumshirn
On Mon, Jan 23, 2017 at 08:34:46AM -0800, Bart Van Assche wrote: > Avoid that issuing a LIP as follows: > > find /sys -name 'issue_lip'|while read f; do echo 1 > $f; done > > triggers the following: > > BUG: unable to handle kernel NULL pointer dereference at (null) > Call Trace: > qla2x00_ab

Re: [PATCH 2/2] qla2xxx: Avoid that issuing a LIP triggers a kernel crash

2017-01-23 Thread Madhani, Himanshu
On 1/23/17, 8:34 AM, "Bart Van Assche" wrote: >Avoid that issuing a LIP as follows: > > find /sys -name 'issue_lip'|while read f; do echo 1 > $f; done > >triggers the following: > >BUG: unable to handle kernel NULL pointer dereference at (null) >Call Trace: > qla2x00_abort_all_cmds+0xed/0x140 [

[PATCH 2/2] qla2xxx: Avoid that issuing a LIP triggers a kernel crash

2017-01-23 Thread Bart Van Assche
Avoid that issuing a LIP as follows: find /sys -name 'issue_lip'|while read f; do echo 1 > $f; done triggers the following: BUG: unable to handle kernel NULL pointer dereference at (null) Call Trace: qla2x00_abort_all_cmds+0xed/0x140 [qla2xxx] qla2x00_abort_isp_cleanup+0x1e3/0x280 [qla2xxx]