Re: [PATCH 2/2] libata-scsi: better style in ata_msense_caching()

On 07/07/2016 03:44 PM, Tom Yan wrote: Sorry I am a bit new in this. Does that mean I should also use {} for the if clause even it has only one line of statement, because I (needed to) use that for the else clause? So it should be like: if ... { ... } else { ... ... } Exactl

Re: [PATCH 2/2] libata-scsi: better style in ata_msense_caching()

Sorry I am a bit new in this. Does that mean I should also use {} for the if clause even it has only one line of statement, because I (needed to) use that for the else clause? So it should be like: if ... { ... } else { ... ... } On 7 July 2016 at 18:55, Sergei Shtylyov wrote: > >

Re: [PATCH 2/2] libata-scsi: better style in ata_msense_caching()

On 7/7/2016 4:43 AM, tom.t...@gmail.com wrote: From: Tom Yan Signed-off-by: Tom Yan diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index bfec66f..e3f5751 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -2424,10 +2424,12 @@ static void modecpy(u8

[PATCH 2/2] libata-scsi: better style in ata_msense_caching()

From: Tom Yan Signed-off-by: Tom Yan diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index bfec66f..e3f5751 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -2424,10 +2424,12 @@ static void modecpy(u8 *dest, const u8 *src, int n, bool changeable) st