Re: [PATCH 2/2] block: support > 16 byte CDBs for SG_IO

2014-07-20 Thread Boaz Harrosh
On 07/20/2014 04:27 PM, Christoph Hellwig wrote: > On Sun, Jul 20, 2014 at 02:47:49PM +0300, Boaz Harrosh wrote: >> >> So two things here: >> - hdr->cmd_len is char so can be MAX of 255. I understand that 4 bytes >> alignment is a SCSI >> thing so you found no point of checking any max size? >

Re: [PATCH 2/2] block: support > 16 byte CDBs for SG_IO

2014-07-20 Thread Christoph Hellwig
On Sun, Jul 20, 2014 at 02:47:49PM +0300, Boaz Harrosh wrote: > > So two things here: > - hdr->cmd_len is char so can be MAX of 255. I understand that 4 bytes > alignment is a SCSI > thing so you found no point of checking any max size? I don't see any point to force the aligmnet - the devices

Re: [PATCH 2/2] block: support > 16 byte CDBs for SG_IO

2014-07-20 Thread Boaz Harrosh
On 07/20/2014 01:23 PM, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig Hi Christoph I've quickly reviewed your code and have a few questions > --- > block/scsi_ioctl.c | 24 +--- > 1 file changed, 17 insertions(+), 7 deletions(-) > > diff --git a/block/scsi_ioc

[PATCH 2/2] block: support > 16 byte CDBs for SG_IO

2014-07-20 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- block/scsi_ioctl.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c index c4e6633..a804f3e 100644 --- a/block/scsi_ioctl.c +++ b/block/scsi_ioctl.c @@ -288,8 +288,6 @@ static