Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-10-04 Thread Linas Vepstas
On Mon, Oct 01, 2007 at 07:27:30PM -0600, Matthew Wilcox wrote: > > The thing to remember is that sym2 is in transition from being a dual > BSD/Linux driver to being a purely Linux driver. I was wondering about that; couldn't tell if the split in the code was historical, or being intentionally m

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-10-02 Thread Linas Vepstas
On Mon, Oct 01, 2007 at 07:27:30PM -0600, Matthew Wilcox wrote: > > Fine by me. Do you have the ability to produce failures on a whim on > your platforms? Yes, although it is very platform specific -- there are actually transistors in the pci bridge chip, which actually short out lines, and so

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-10-01 Thread Matthew Wilcox
On Mon, Oct 01, 2007 at 05:41:32PM -0500, Linas Vepstas wrote: > On Mon, Oct 01, 2007 at 02:12:47PM -0600, Matthew Wilcox wrote: > > I think the fundamental problem is that completions aren't really > > supposed to be used like this. Here's one attempt at using completions > > perhaps a little mor

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-10-01 Thread Linas Vepstas
On Mon, Oct 01, 2007 at 02:12:47PM -0600, Matthew Wilcox wrote: > > I think the fundamental problem is that completions aren't really > supposed to be used like this. Here's one attempt at using completions > perhaps a little more the way they're supposed to be used, Yes, that looks very good t

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-10-01 Thread Matthew Wilcox
On Thu, Sep 27, 2007 at 06:34:37PM -0500, Linas Vepstas wrote: > Good catch. But no ... and I had to study this a bit. Bear with me: I agree with the analysis which I've now snipped. > I think the race you describe above is harmless. The first time > that sym_eh_handler() will run, it will be wit

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-09-27 Thread Linas Vepstas
On Thu, Sep 27, 2007 at 04:10:31PM -0600, Matthew Wilcox wrote: > In the error handler, we wait_for_completion(io_reset_wait). > In sym2_io_error_detected, we init_completion(io_reset_wait). > Isn't it possible that we hit the error handler before we hit the > io_error_detected path, and thus the c

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-09-27 Thread Matthew Wilcox
On Thu, Sep 27, 2007 at 05:00:22PM -0500, Linas Vepstas wrote: > On Wed, Sep 26, 2007 at 09:02:16AM -0600, Matthew Wilcox wrote: > > I'm a little concerned by the mention of MMIO. It's entirely possible > > for the sym2 driver to be using ioports to access the card rather than > > MMIO. Is it sim

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-09-27 Thread Linas Vepstas
On Wed, Sep 26, 2007 at 09:02:16AM -0600, Matthew Wilcox wrote: > On Fri, Apr 20, 2007 at 03:47:20PM -0500, Linas Vepstas wrote: > > Implement the so-called "first failure data capture" (FFDC) for the > > symbios PCI error recovery. After a PCI error event is reported, > > the driver requests that

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-09-26 Thread Matthew Wilcox
On Fri, Apr 20, 2007 at 03:47:20PM -0500, Linas Vepstas wrote: > Implement the so-called "first failure data capture" (FFDC) for the > symbios PCI error recovery. After a PCI error event is reported, > the driver requests that MMIO be enabled. Once enabled, it > then reads and dumps assorted stat

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-05-17 Thread Linas Vepstas
On Wed, May 09, 2007 at 03:26:21PM -0500, Linas Vepstas wrote: > Hi Matthew, > > I had been hoping these patches might make it into 2.6.22, > ... this is a nag note; please forward upstream. ... should I repost the patches? --linas - To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-05-09 Thread Linas Vepstas
Hi Matthew, I had been hoping these patches might make it into 2.6.22, ... this is a nag note; please forward upstream. --linas On Fri, Apr 20, 2007 at 03:47:20PM -0500, Linas Vepstas wrote: > > Implement the so-called "first failure data capture" (FFDC) for the > symbios PCI error recovery. A

[PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-04-20 Thread Linas Vepstas
Implement the so-called "first failure data capture" (FFDC) for the symbios PCI error recovery. After a PCI error event is reported, the driver requests that MMIO be enabled. Once enabled, it then reads and dumps assorted status registers, and concludes by requesting the usual reset sequence. (