Christoph Hellwig wrote:
On Wed, Oct 03, 2007 at 01:59:23PM -0400, Jeff Garzik wrote:
Come on. The patches were posted for comments, and Rolf commented.
Don't give him a hard time for a valid comment.
Sorry, but these comments are utterly useless. It's not like we're doing
anything related t
On Wed, Oct 03, 2007 at 01:59:23PM -0400, Jeff Garzik wrote:
> Come on. The patches were posted for comments, and Rolf commented.
> Don't give him a hard time for a valid comment.
Sorry, but these comments are utterly useless. It's not like we're doing
anything related to dma mapping, but just
Christoph Hellwig wrote:
On Wed, Oct 03, 2007 at 07:32:24PM +0200, Rolf Eike Beer wrote:
It's not about passing NULL there. We need to do that. But we should call it
with NULL as argument and not with ha->pdev to make this obvious.
Feel free to send your cleanup patches once we've finished doi
On Wed, Oct 03, 2007 at 07:32:24PM +0200, Rolf Eike Beer wrote:
> It's not about passing NULL there. We need to do that. But we should call it
> with NULL as argument and not with ha->pdev to make this obvious.
Feel free to send your cleanup patches once we've finished doing the
important heavy l
Christoph Hellwig wrote:
> On Tue, Oct 02, 2007 at 07:20:38PM +0200, Rolf Eike Beer wrote:
> > Same thing as in ISA patch: this is not PCI and we should not hide what
> > we're doing so dma_alloc_consistent(NULL, ...) is better IMHO.
>
> passing NULL is the documented way to deal with ISA/EISA devi
On Tue, Oct 02, 2007 at 07:20:38PM +0200, Rolf Eike Beer wrote:
> Same thing as in ISA patch: this is not PCI and we should not hide what we're
> doing so dma_alloc_consistent(NULL, ...) is better IMHO.
passing NULL is the documented way to deal with ISA/EISA devices with
the old pci dma api. An
Boaz Harrosh wrote:
> Split eisa probing into it's own helper, and do proper error unwinding.
> Protect EISA probind by the proper CONFIG_EISA symbol.
>
> Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
> @@ -5694,6 +5582,148 @@ static int gdth_isa_probe_one(struct
> scsi_host_template *shtp,
Split eisa probing into it's own helper, and do proper error unwinding.
Protect EISA probind by the proper CONFIG_EISA symbol.
Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
---
drivers/scsi/gdth.c | 270 ---
1 files changed, 150 insertions(
8 matches
Mail list logo
