Re: [PATCH 17/18] srp_transport: Add transport layer recovery support

2012-08-19 Thread David Dillow
On Sat, 2012-08-18 at 10:50 +, Bart Van Assche wrote: > On 07/16/12 22:28, David Dillow wrote: > > On Mon, 2012-07-16 at 18:07 -0400, Mike Christie wrote: > >> Not sure about the ping code, but I think the dev loss tmo and fast io > >> fail related stuff should go to scsi_transport_template. We

Re: [PATCH 17/18] srp_transport: Add transport layer recovery support

2012-08-18 Thread Bart Van Assche
On 07/16/12 22:28, David Dillow wrote: > On Mon, 2012-07-16 at 18:07 -0400, Mike Christie wrote: >> On 01/14/2012 05:56 AM, Bart Van Assche wrote: >>> Add the necessary functions in the SRP transport module to allow >>> an SRP initiator driver to implement transport layer recovery. >> >> I was upda

Re: [PATCH 17/18] srp_transport: Add transport layer recovery support

2012-07-17 Thread bart
> On Mon, 2012-07-16 at 18:07 -0400, Mike Christie wrote: >> On 01/14/2012 05:56 AM, Bart Van Assche wrote: >> > Add the necessary functions in the SRP transport module to allow >> > an SRP initiator driver to implement transport layer recovery. >> >> I was updating my iscsi dev loss patch when I s

Re: [PATCH 17/18] srp_transport: Add transport layer recovery support

2012-07-16 Thread David Dillow
On Mon, 2012-07-16 at 18:38 -0400, Mike Christie wrote: > On 07/16/2012 04:28 PM, David Dillow wrote: > > On Mon, 2012-07-16 at 18:07 -0400, Mike Christie wrote: > >> For the ping code, does it use TUR because there is not a transport way > >> to test the path/port/transport/interconnect? > > > >

Re: [PATCH 17/18] srp_transport: Add transport layer recovery support

2012-07-16 Thread Mike Christie
On 07/16/2012 04:28 PM, David Dillow wrote: > On Mon, 2012-07-16 at 18:07 -0400, Mike Christie wrote: >> On 01/14/2012 05:56 AM, Bart Van Assche wrote: >>> Add the necessary functions in the SRP transport module to allow >>> an SRP initiator driver to implement transport layer recovery. >> >> I was

Re: [PATCH 17/18] srp_transport: Add transport layer recovery support

2012-07-16 Thread David Dillow
On Mon, 2012-07-16 at 18:07 -0400, Mike Christie wrote: > On 01/14/2012 05:56 AM, Bart Van Assche wrote: > > Add the necessary functions in the SRP transport module to allow > > an SRP initiator driver to implement transport layer recovery. > > I was updating my iscsi dev loss patch when I saw this

Re: [PATCH 17/18] srp_transport: Add transport layer recovery support

2012-07-16 Thread Mike Christie
On 07/16/2012 04:07 PM, Mike Christie wrote: > For the ping code, does it use TUR because there is not a transport way > to test the path/port/transport/interconnect? Maybe not transport as in SCSI transport method, but what about something similar to using a ICMP ping for testing the network with

Re: [PATCH 17/18] srp_transport: Add transport layer recovery support

2012-07-16 Thread Mike Christie
On 01/14/2012 05:56 AM, Bart Van Assche wrote: > Add the necessary functions in the SRP transport module to allow > an SRP initiator driver to implement transport layer recovery. > This includes: > - A ping mechanism to check whether the transport layer is still > operational. > - Support for imp