Re: [PATCH 16/22] advansys: Eliminate prototypes

2007-09-17 Thread Matthew Wilcox
On Mon, Sep 17, 2007 at 08:17:21AM +0900, FUJITA Tomonori wrote: > I updated the previous patch for your latest patchset. I removed the > sg chaining support so you can send it to scsi-misc now. > > Just a one-line patch is necessary for the sg chaining support. It'll > be push to mainline via Jen

Re: [PATCH 16/22] advansys: Eliminate prototypes

2007-09-16 Thread FUJITA Tomonori
On Sun, 16 Sep 2007 17:03:50 -0600 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Mon, Sep 17, 2007 at 07:41:06AM +0900, FUJITA Tomonori wrote: > > On Sun, 16 Sep 2007 09:31:34 -0600 > > Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > > > > On Sat, Sep 15, 2007 at 09:39:05AM -0500, James Bottomley

Re: [PATCH 16/22] advansys: Eliminate prototypes

2007-09-16 Thread Matthew Wilcox
On Mon, Sep 17, 2007 at 07:41:06AM +0900, FUJITA Tomonori wrote: > On Sun, 16 Sep 2007 09:31:34 -0600 > Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > > On Sat, Sep 15, 2007 at 09:39:05AM -0500, James Bottomley wrote: > > > I get a compile failure at this point in your patch sequence: > > > > Than

Re: [PATCH 16/22] advansys: Eliminate prototypes

2007-09-16 Thread FUJITA Tomonori
On Sun, 16 Sep 2007 09:31:34 -0600 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Sat, Sep 15, 2007 at 09:39:05AM -0500, James Bottomley wrote: > > I get a compile failure at this point in your patch sequence: > > Thanks. I'd been compiling with CONFIG_ISA=n, so hadn't spotted these > two proble

Re: [PATCH 16/22] advansys: Eliminate prototypes

2007-09-16 Thread Matthew Wilcox
On Sat, Sep 15, 2007 at 09:39:05AM -0500, James Bottomley wrote: > I get a compile failure at this point in your patch sequence: Thanks. I'd been compiling with CONFIG_ISA=n, so hadn't spotted these two problems. I've set it back to Y now. > I've put 1-15 in .. could you rebase against scsi-mis

Re: [PATCH 16/22] advansys: Eliminate prototypes

2007-09-15 Thread James Bottomley
On Sun, 2007-09-09 at 08:56 -0600, Matthew Wilcox wrote: > Rearrange a lot of the functions in the file to get rid of all the > forward > declarations. I get a compile failure at this point in your patch sequence: CC [M] drivers/scsi/advansys.o drivers/scsi/advansys.c:72:2: warning: #warning t

Re: [PATCH 16/22] advansys: Eliminate prototypes

2007-09-09 Thread Matthew Wilcox
On Sun, Sep 09, 2007 at 11:29:34AM -0400, Jeff Garzik wrote: > What thoughts, if any, have been given to post-patch code arrangement, > besides eliminating prototypes? > This always struck me as a counterproductive exercise when taken by > itself. Eliminating prototypes saves me from an extra go

Re: [PATCH 16/22] advansys: Eliminate prototypes

2007-09-09 Thread Jeff Garzik
Matthew Wilcox wrote: Rearrange a lot of the functions in the file to get rid of all the forward declarations. What thoughts, if any, have been given to post-patch code arrangement, besides eliminating prototypes? This always struck me as a counterproductive exercise when taken by itself.