Re: [PATCH 16/20] scsi_dh_alua: Use workqueue for RTPG

2015-07-25 Thread Hannes Reinecke
On 07/24/2015 05:21 PM, Christoph Hellwig wrote: >> +charwork_q_name[264]; > > create_workqueue and friends now accept printf-like format > string, so there is no need for this temporary buffer. > >> +int error; >> +struct completion init_

Re: [PATCH 16/20] scsi_dh_alua: Use workqueue for RTPG

2015-07-24 Thread Christoph Hellwig
> + charwork_q_name[264]; create_workqueue and friends now accept printf-like format string, so there is no need for this temporary buffer. > + int error; > + struct completion init_complete; Please rename error to init_error and only ass

[PATCH 16/20] scsi_dh_alua: Use workqueue for RTPG

2015-07-08 Thread Hannes Reinecke
The current ALUA device_handler has two drawbacks: - We're sending a 'SET TARGET PORT GROUP' command to every LUN, disregarding the fact that several LUNs might be in a port group and will be automatically switched whenever _any_ LUN within that port group receives the command. - Whenever a L